-
Notifications
You must be signed in to change notification settings - Fork 71
config: update CodeRabbit config #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rsoaresd
wants to merge
6
commits into
codeready-toolchain:master
Choose a base branch
from
rsoaresd:clean_coderrabit_config_h
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−7
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
100cc87
clean CodeRabbit config
rsoaresd 6345005
Merge branch 'master' into clean_coderrabit_config_h
rsoaresd 4103532
update
rsoaresd 93f1900
move .coderabbit.yaml to project root
rsoaresd 332ff54
rephrase instructions
rsoaresd be1e891
Merge branch 'master' into clean_coderrabit_config_h
rsoaresd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,24 @@ | ||
| inheritance: true | ||
| knowledge_base: | ||
| linked_repositories: | ||
| - repository: 'codeready-toolchain/toolchain-common' | ||
| - repository: 'codeready-toolchain/registration-service' | ||
| instructions: > | ||
| toolchain-common contains shared controllers, utilities, and libraries used by host-operator. | ||
| registration-service is the HTTP API and signup frontend, deployed by host-operator. When reviewing changes: | ||
| - Check if changes to registration-service SA/Role/RoleBinding rules stay consistent with the cache warm-up list in registration-service. | ||
| - Verify that ToolchainConfig spec or reconciliation changes affecting .spec.host.registrationService fields or referenced secrets stay aligned with registration-service's runtime config readers. | ||
| - Check if ToolchainStatus health aggregation changes still match registration-service's GET /api/v1/health response contract. | ||
| - Verify that REGISTRATION_SERVICE_IMAGE wiring or template parameter changes match the embedded template's expected inputs. | ||
| - Flag changes to shared codeready-toolchain/api types or toolchain-common utilities that registration-service also consumes. | ||
| - For signup or proxy flow changes, call out when a sibling PR in registration-service or toolchain-e2e may be needed. | ||
|
|
||
| When reviewing host-operator changes: | ||
| - Check if host-operator is using deprecated or outdated patterns from toolchain-common when newer/better utilities exist. | ||
| - Verify behavioral assumptions — if host-operator expects specific return values or side effects from toolchain-common functions, check if that behavior is actually implemented. | ||
| - If host-operator duplicates logic that already exists in toolchain-common (pkg/cluster, pkg/condition, pkg/configuration, pkg/status), suggest using the shared implementation instead. | ||
| - Flag if host-operator is making assumptions about toolchain-common's internal state or behavior that isn't documented or guaranteed. | ||
| - repository: 'codeready-toolchain/member-operator' | ||
| instructions: > | ||
| member-operator runs on member clusters and reconciles resources created cross-cluster by host-operator. When reviewing changes: | ||
| - Check if changes to UserAccount or NSTemplateSet fields, labels, conditions, or status match what member-operator's useraccount and nstemplateset controllers expect. | ||
| - Verify that ToolchainConfig sync logic or MemberOperatorConfig spec changes stay compatible with member-operator's memberoperatorconfig controller. | ||
| - Check if ToolchainStatus aggregation assumptions match the MemberStatus fields member-operator actually produces. | ||
| - Verify that ToolchainCluster RBAC changes still grant member-operator's controllers the required access. | ||
| - Check if tier template changes (NSTemplateTier, TierTemplate, TierTemplateRevision) stay compatible with member-operator's nstemplateset controller, which reads them via a cached host client. | ||
| - Flag if SpaceBindingRequest/SpaceRequest watch scope or RBAC changes could desync member-side resources. | ||
| - Flag changes to shared codeready-toolchain/api types or toolchain-common utilities that member-operator also consumes. | ||
| - For provisioning flow changes, call out when a sibling PR in member-operator or toolchain-e2e may be needed. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.