Skip to content

Conversation

@ycong1129
Copy link
Collaborator

@ycong1129 ycong1129 commented Jan 7, 2026

Implemented the last three sections of the Landing Page.
Added upcoming Events, featured Member Creations.
Basic layout and styling in Tailwind completed.

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation
截屏2026-01-07 18 17 46 截屏2026-01-07 18 18 05

Related issue

Copy link
Contributor

@laurenpudz laurenpudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off to a good start 👍

Copy link
Contributor

@laurenpudz laurenpudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! could you please also merge main into this branch and resolve conflicts so we can see what it looks like with the first sections of the landing page above it. Thanks!

id: 1,
title: "Summer 2026 Game Jam",
time: "Monday 24th Oct 11:00am–4:00pm",
image: "/placeholder.png",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please change this and the image fields on lines 180 and 186 to the already existing landing_placeholder for consistency.

id: 1,
title: "Cool Game",
description: "Cool game is a game about being cool.",
image: "/placeholder.png",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also change this, line 201 and line 207 to landing_placeholder

Comment on lines +395 to +400
<Image
src={game.image}
alt={game.title}
width={340}
height={195}
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image The spacing doesn't look quite right here, the pictures are too close to the game title. They should also have rounded corners, as in the figma

Comment on lines +323 to +330
<div className="flex h-44 w-full items-center justify-center rounded-lg bg-muted-foreground">
<Image
src={event.image}
alt={event.title}
width={60}
height={60}
/>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need the image here. You don't need to make the image small and center it in a box, instead, please just make the image the size that the box currently is, similar to what you've done with the game images. Please also make sure the images corners are rounded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create the last three sections of the landing page

3 participants