Issue 7 Individual Game Pages Api and Issue 18 Game Contributors Model #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dersforcauses/game-dev into issue-7-Individual_game_pages This because my branch and the 'origin/issue-7-Individual_game_pages' have diverged
…dersforcauses/game-dev into issue-7-Individual_game_pages Fixed issue with the server side models.py, migrated the two new models games and events
…ternal image domains for better asset management
….io account the value is added
…ignment and spacing
…dersforcauses/game-dev into issue-7-Individual_game_pages-backend Pulling any changes from issue-7-Individual_game_pages
…ages-backend Add backend changes of Itch Emed
…g and layout responsive
… field and upload location, events foregein key can be empty or set to empty if event is removed, if isItch is true then hostURL is itch.io game id 7 digit
…, contributors, and embed Itch.io game
…st ItchEmbed component styling
…dering and improve component structure
…e Games via /admin/
…id, and linkedto member page
… colours to match Figma (hard-coded on page for now). Title, table and description now below with text-wrapping around the table. Margins, padding and spacing still to be fixed.
…ning of table still in progress.
…global variables.
…ark theme with a drop shadow to blend with the site colour palette. Moved isItch conditional to only cover the ItchEmbed and not the artwork section as well.
… Updated a couple of colours to use global variables instead of hardcoded values.
…aring game data for frontend
…e page as data is from useGames hook
…all games we query specific games by their id from the frontend
…ous notes when building component.
RadinMan
changed the title
2 tasks
…t was overwritten with the itchEmbedID. Updated the database schema to have both hostURL and itchEmbedID so that both the Host Site field on the page and the itch embed both work.
Collaborator
|
PR conflicts resolved, good for review now @SafetyInObscurity |
Collaborator
|
FYI: Database schema has been modified to add the itchEmbedID field as this needs to be stored separate to the hostURL for the itch embed to work while still having the correct link to the game in the description. This was discussed earlier, but we may wish to update the schema linked on the Notion or any documentation given to the client if applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR History Note
This Pull Request is the continuation of PR 25 - Individual game pages frontend preview, the feedback from that PR were resolved and address in that PR. Additional changes and further improvements including the below has since been made that has required this new PR and the closing of the old one.
Change Summary
Added full support for individual game pages Issue 7 - Individual Game Pages including backend APIs for querying a single game from Games Database based on
idin "http://localhost:3000/games/" to then render in the frontend. Our frontend consists of a hook ui component responsible for fetching data from our backend api route "api/games/", and then the games/[id].tsx renders the page with embedded itch.io widget for easy accessibility to the Games.Additionally we also incorporate Issue 18 - Game Contributors Model where as long as a Member exist and a Game exist, admins using Django admin page can go to the Game Contributor table and add the Member to a Game with their role.
Change Form
Other Information
In the individual games page frontend under the game details, the Host Site has faced some issue. @nicostellar will be fixing this with the upcoming days and will provide update.
Related issue