Skip to content

feat(bling): add proposal (orçamento) tools - #180

Merged
rapguit merged 4 commits into
codespar:mainfrom
palandri:feat/proposals-endpoint
Jul 13, 2026
Merged

feat(bling): add proposal (orçamento) tools#180
rapguit merged 4 commits into
codespar:mainfrom
palandri:feat/proposals-endpoint

Conversation

@palandri

@palandri palandri commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Add 6 new MCP tools for commercial proposals (propostas comerciais): list, get, create, update, delete, update_status.

Midas DipLab added 2 commits June 6, 2026 14:26
Add 6 new tools for commercial proposals (propostas comerciais):
- list_proposals
- get_proposal
- create_proposal
- update_proposal
- delete_proposal
- update_proposal_status

Endpoints: /propostas-comerciais (CRUD + PATCH status)
Resolves contact names inline when expandContact=true.
Uses sequential lookups to avoid rate limiting.
@rapguit

rapguit commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution, and welcome — first PR here.

The 6 proposal tools themselves look solid: tool shapes are consistent with the rest of the Bling surface, REST paths against /propostas-comerciais/... match the API, and expandContact is gated + fails per-contact so a missing/blocked lookup doesn't take the whole list down.

Three things to clean up before this can land:

  1. MANAGED_TIER_HINT is removed in packages/erp/bling/src/index.ts. The instructions: MANAGED_TIER_HINT argument on new Server(...) is the standard pattern every server in this catalog ships (~115 servers). It's likely a side-effect of an older base branch (the hint was added after you forked); please restore the constant + the instructions: MANAGED_TIER_HINT argument so this server stays consistent with the rest.

  2. package-lock.json drift: the lockfile change is +433/-99 and includes version bumps + new workspace links for ~12 packages that aren't part of this feature (e.g. @codespar/mcp-btg, mcp-coinbase-cdp, mcp-paypal, mcp-iniciador, etc). That's from running npm install on a stale base. A clean rebase on current main + npm install should reduce the lockfile diff to just whatever the proposal feature actually needs.

  3. @types/express added at root devDependencies without a corresponding consumer — Bling's index.ts doesn't import Express. If it's unintentional, please drop the entry; if it's preparation for a follow-up, happy to hear the context.

Once those are addressed I'll re-review and merge. Thanks again!

@rapguit rapguit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formalizing as a changes-requested review for visibility — the three points from my earlier comment (#180 (comment)) still stand:

  1. Restore MANAGED_TIER_HINT (regression).
  2. Rebase on main + clean npm install to drop the unrelated lockfile drift.
  3. Drop the orphan @types/express devDep (or justify it).

Re-request review once those land. Thanks!

rapguit and others added 2 commits July 13, 2026 12:22
# Conflicts:
#	package-lock.json
#	package.json
…tools

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

@rapguit rapguit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal (orçamento) tools, @palandri — clean tool shapes and solid coverage. I went ahead and applied the three requested changes to get this landed: restored the MANAGED_TIER_HINT, rebased on main for a clean lockfile (dropped the unrelated drift), and removed the orphan @types/express devDep — plus bumped the tool-count test to 34. CI is green across build/test, catalog audit, and secret scan. 🚀

@rapguit
rapguit merged commit f13f06b into codespar:main Jul 13, 2026
3 checks passed
@palandri

palandri commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

I'm really sorry for the lack of response on this @rapguit. I've been dealing with some health issues recently, which kept me from addressing your requested changes. Thank you so much for stepping in, picking this up, and getting it over the finish line. I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants