Do not allow for a word to start or end with punctuation symbols#3588
Open
yarikoptic wants to merge 3 commits intocodespell-project:mainfrom
Open
Do not allow for a word to start or end with punctuation symbols#3588yarikoptic wants to merge 3 commits intocodespell-project:mainfrom
yarikoptic wants to merge 3 commits intocodespell-project:mainfrom
Conversation
The inspired for me to look use case - https://github.com/INTERSECT-SDK/python-sdk/pull/19/files/33da9ff31d6162caa0dfc1a1155f321e6d68b1cc#diff-10380fd6e5ecb84c1ae11e135982739946c5aff1a50499378db397cf5034f54e And then I found the issue this - Close codespell-project#3305 Although may be I am missing the use-cases/problems @DimitriPapadopoulos and @mdeweerd discussed back then
…e character "words")
yarikoptic
changed the title
yarikoptic
added a commit
to yarikoptic/python-sdk
that referenced
this pull request
Nov 22, 2024
codespell from codespell-project/codespell#3588 === Do not change lines below === { "chain": [], "cmd": "codespell -w ./tests/unit/test_schema_invalids.py", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
yarikoptic
added a commit
to yarikoptic/python-sdk
that referenced
this pull request
Nov 22, 2024
codespell from codespell-project/codespell#3588 === Do not change lines below === { "chain": [], "cmd": "codespell -w ./tests/unit/test_schema_invalids.py", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
1 task
Member
|
I haven't looked deeply but am I right that this single-line comment: would get handled differently from this multi-line one ? To me these are essentially the same code comment so it's weird that codespell would treat them differently. It's even a bit weird to try to keep track of the quotation level in any way as it seems brittle, especially given people can forget start and end quotes from time to time |
Contributor
Author
|
since no space should be in "word regex", we should be robust to such examples -- those should be separate words (on one line or not) |
Lance-Drane
pushed a commit
to INTERSECT-SDK/python-sdk
that referenced
this pull request
Nov 25, 2024
codespell from codespell-project/codespell#3588 === Do not change lines below === { "chain": [], "cmd": "codespell -w ./tests/unit/test_schema_invalids.py", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inspired for me to look use case
And then I found the issue this
Although may be I am missing the use-cases/problems @DimitriPapadopoulos and @mdeweerd discussed back then
Edits:
After I pushed, I realized that we have a use case where we are not covering
``LaTeX''way to quote. So were and keep missing those. Do you think I should add regex for them too?some gory details on me discovering were' and other "typos" in dictionaries
ok -- tests fail due to the typo:
and apparently it is not a single one like that left:
but some of those IMHO make no sense to list
'if correction is also with'which is AFAIK is not a part of the word, i.e. I think following should be simply removed (replaced with ones with'):First I wondered if that is the case worth striving for fixing: since were is a legit word, it could have also been forgotten
'somewhere long before, e.g. in awhich would be programming language gotcha, not a typo.
FWIW
were'was added originally infiles') at some point existed but then were removed as well e.g. in 8804b93In leftover cases it boils down to
'is a part of the word, and thus could be present in the typo in alternative location"(I would still argue to exclude
were')..