Exit properly on exclude-file error#3688
Open
DimitriPapadopoulos wants to merge 1 commit intocodespell-project:mainfrom
Open
Exit properly on exclude-file error#3688DimitriPapadopoulos wants to merge 1 commit intocodespell-project:mainfrom
DimitriPapadopoulos wants to merge 1 commit intocodespell-project:mainfrom
Conversation
DimitriPapadopoulos
requested review from
larsoner and
peternewman
as code owners
DimitriPapadopoulos
force-pushed
the
exclude-file
branch
from
af20785 to
940af1e
Compare
If the exclude-file argument cannot be read, catch the exception and exit properly with a meaningful error message.
DimitriPapadopoulos
force-pushed
the
exclude-file
branch
from
940af1e to
34338bd
Compare
larsoner
reviewed
Apr 11, 2025
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Worth adding some test that these can actually be hit? Makes sure that things like e.strerror actually work in the strings
Collaborator
Author
|
@larsoner Do you think we should exit when a "secondary" file argument is missing, or just ignore the missing file as suggested in #3687 (comment)? |
granjadenbelg02
approved these changes
Oct 11, 2025
Member
|
Ahh for an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
exclude-fileargument cannot be read, catch the exception and exit properly with a meaningful error message.Fixes #3687.