Open
Conversation
victoriacheng15
force-pushed
the
feature/event-component
branch
from
a78067a to
3b5d995
Compare
Collaborator
Author
|
add |
lindan4
reviewed
Feb 8, 2025
|
|
||
| p { | ||
| margin: 0; | ||
| font-size: 1.25rem; |
Collaborator
There was a problem hiding this comment.
Out of curiosity, why are using rem sizes?
Collaborator
Author
There was a problem hiding this comment.
rem is relative to the root font size of the document, making it more consistent and scalable across different screen sizes. This helps with accessibility and responsiveness. Plus, it's my habit to use rem for better maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18