Open
Conversation
lindan4
requested review from
a team
and removed request for
NobleTyler and
lindan4
lindan4
reviewed
Jan 19, 2025
tsconfig.json
Outdated
Comment on lines
+2
to
+6
| "extends": "astro/tsconfigs/base", | ||
| "compilerOptions": { | ||
| "strictNullChecks": true, // add if using `base` template | ||
| "allowJs": true // required, and included with all Astro templates | ||
| } |
Author
There was a problem hiding this comment.
I initially had that when I was using defining the types but I forgot to delete it since Im no longer doing this. I updated my pull request deleting that change. I also fix some responsive issues.
…hat are no longer needed
…hat are no longer needed
lindan4
reviewed
Feb 8, 2025
Comment on lines
+8
to
+12
| import type { CollectionEntry } from 'astro:content'; | ||
|
|
||
| interface SpeakerContentProps { | ||
| speaker: CollectionEntry<'speakers'> | ||
| } |
Collaborator
There was a problem hiding this comment.
I like how TypeScript is being used here
Collaborator
|
You will have to rebase the PR as there are merge conflicts. I know that you rebased the PR earlier, but another approach would be to run:
and work through the merge conflicts one by one |
lindan4
requested changes
Feb 8, 2025
Collaborator
lindan4
left a comment
lindan4
left a comment
There was a problem hiding this comment.
I am unable to start the project from your PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the speaker section of the website.
This was accomplished by creating two components: SpeakerHeader and SpeakerCard. The SpeakerHeader contains a hard-coded title and the description of the section. For the SpeakerCard component, I used Content Collections to render the content of each card. The data of each card is currently stored in a JSON file (to streamline the rendering process) and passed as a Prop to the component using the CollectionEntry utility. I used this approach to ensure flexibility and scalability in case we add more speakers or if we want to link our content using Contentful in the future.