Open
Conversation
lindan4
reviewed
Jan 19, 2025
What did we do? Update documentation by replacing npm commands with pnpm commands Why was it done? Since we are using pnpm, different files will be generated.
What was done? Ran pnpm dlx @astrojs/upgrade tp upgrade Astro to the latest version. why was this done? To keep Astro up to date. This is major version upgrade, and considering how early we are in the development of the project, it is better to do it now.
Code to Cloud nav bar
add hero component
lindan4
reviewed
Feb 8, 2025
| <meta name="description" content="Astro description" /> | ||
| <meta name="viewport" content="width=device-width" /> | ||
| <link rel="icon" type="image/svg+xml" href="/favicon.svg" /> | ||
| <link href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.0.0-beta3/css/all.min.css" rel="stylesheet"> |
Author
There was a problem hiding this comment.
This link was used to fetch icons from an external dependency (Font Awesome). Would it be cleaner to use PNGs for icons instead, or is there a way to install Font Awesome (or similar icon libraries) as a dependency via pnpm?
lindan4
reviewed
Feb 8, 2025
src/components/FooterContent.astro
Outdated
Comment on lines
+3
to
+4
| <h1>Collaborate with us</h1> | ||
| <p>Interested in further connecting with us?<br>Engage through our socials, or leave us a message below.</p> |
Collaborator
There was a problem hiding this comment.
What do you say to putting the text here in a div with 2 p elements instead of using a br tag?
lindan4
requested changes
Feb 8, 2025
Collaborator
lindan4
left a comment
lindan4
left a comment
There was a problem hiding this comment.
@haywirebanana you will have to rebase this PR as there are merge conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created the Footer, but removed the "sign up to present" button.
(Idea: User inputs email to subscribe?)