Conversation
What did we do? Update documentation by replacing npm commands with pnpm commands Why was it done? Since we are using pnpm, different files will be generated.
What was done? Ran pnpm dlx @astrojs/upgrade tp upgrade Astro to the latest version. why was this done? To keep Astro up to date. This is major version upgrade, and considering how early we are in the development of the project, it is better to do it now.
Code to Cloud nav bar
add hero component
@haywirebanana according the mockup we have, it looks like your designs may have to be changed. These include, but are not limited to:
|
| <details class="accordion"> | ||
| <summary class="accordion-header"> | ||
| <div class="header-content"> | ||
| <span class="time">{time}</span> | ||
| <span class="title">{title}</span> | ||
| <i class="fa fa-caret-down toggle-icon"></i> | ||
| </div> | ||
| </summary> | ||
| <div class="accordion-body"> | ||
| <p class="body-text">{body}</p> | ||
| <p class="speaker">{speaker ? `Speaker: ${speaker}` : ''}</p> | ||
| </div> | ||
| </details> |
There was a problem hiding this comment.
I think we will have to use another outer element to match designs. details would be a lot more convenient though
There was a problem hiding this comment.
With our previous discussions, I needed to visualize what it would look like compared to the old "version" in Figma where it was just plain text. I created that visual on Figma on a whim. Should I adhere to it?
I figured details/summary would be convenient as we are working on a static website, is there an alternative I can use?
src/components/Dropdown.astro
Outdated
| font-size: 25px; | ||
| } | ||
|
|
||
| .body-text { |
There was a problem hiding this comment.
How about accordion-body-text?
src/layouts/Layout.astro
Outdated
| <meta name="viewport" content="width=device-width" /> | ||
| <link rel="icon" type="image/svg+xml" href="/favicon.svg" /> | ||
| <meta name="generator" content={Astro.generator} /> | ||
| <link href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.4/css/all.min.css" rel="stylesheet" /> |
There was a problem hiding this comment.
Refer to comments on feature/footer branch
lindan4
left a comment
lindan4
left a comment
There was a problem hiding this comment.
You'll have to make changes, but also rebase your branch as there are merge conflicts.
4 participants
I tried to implement a collapsable/accordion feature for the different dropdowns, but was unsure about how to deal with some HTMLAttribute errors so I decided to go for Detail & Summary Tags for ease of dealing with event handlers.