Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Google Gemini model endpoint used by AiAnalysisService to address a minor issue in AI analysis generation.
Changes:
- Switched the Gemini
generateContentmodel in the hard-coded API URL fromgemini-3.1-flash-litetogemini-2.5-flash.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| private final IRankHistoryService rankHistoryService; | ||
|
|
||
| private static final String GEMINI_API_URL = "https://generativelanguage.googleapis.com/v1beta/models/gemini-3.1-flash-lite:generateContent"; | ||
| private static final String GEMINI_API_URL = "https://generativelanguage.googleapis.com/v1beta/models/gemini-2.5-flash:generateContent"; |
There was a problem hiding this comment.
The Gemini endpoint/model is hard-coded in a constant. Since model names can change and may differ across environments, consider moving the model (or full URL) to configuration (e.g., application.properties via @value) alongside the API key so updates don’t require a redeploy and can be validated per environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.