Feat(19)-Fixed minor bug and added evidences#70
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates API documentation security annotations, adjusts Docker Compose MySQL credentials/healthcheck tuning for the separated deployment setup, and adds image “evidence” assets.
Changes:
- Add
@SecurityRequirement(name = "bearerAuth")to multiple controllers to mark endpoints as requiring JWT auth in Swagger. - Update
docker-compose-separated.ymlto use a non-root MySQL user/password for the backend and expand MySQL healthcheck timings. - Add new evidence images and adjust backend build deps to include the MySQL connector at runtime.
Reviewed changes
Copilot reviewed 6 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/images/QualityGate.JPG | Adds a new evidence screenshot (contains EXIF/XMP metadata). |
| utils/images/Admin.JPG | Adds a new evidence screenshot (contains EXIF/XMP metadata). |
| docker/docker-compose-separated.yml | Switch backend DB creds to ${MYSQL_USER}/${MYSQL_PASSWORD} and tune MySQL healthcheck. |
| backend/src/main/java/com/tfg/tfg/controller/UserController.java | Marks controller as requiring bearerAuth in OpenAPI docs. |
| backend/src/main/java/com/tfg/tfg/controller/DashboardController.java | Marks controller as requiring bearerAuth in OpenAPI docs. |
| backend/src/main/java/com/tfg/tfg/controller/AdminController.java | Marks controller as requiring bearerAuth in OpenAPI docs. |
| backend/src/main/java/com/tfg/tfg/config/OpenApiConfig.java | Removes global security requirement item (but leaves an unused import). |
| backend/pom.xml | Makes MySQL connector available beyond test scope. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
43
to
49
| .servers(List.of( | ||
| new Server() | ||
| .url("https://localhost") | ||
| .description("Local development server (HTTPS)"))) | ||
| .addSecurityItem(new SecurityRequirement() | ||
| .addList(securitySchemeName)) | ||
| .components(new Components() | ||
| .addSecuritySchemes(securitySchemeName, new SecurityScheme() | ||
| .name(securitySchemeName) |
Comment on lines
+24
to
+25
| SPRING_DATASOURCE_USERNAME: "${MYSQL_USER}" | ||
| SPRING_DATASOURCE_PASSWORD: "${MYSQL_PASSWORD}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.