Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Oracle Kubernetes Engine Terraform configuration to newer Kubernetes versions and aligns node image selection with the configured cluster version, while also changing the Autonomous Database lifecycle behavior. It fits into the IaC layer that provisions the SPIRITBLADE runtime infrastructure on OCI.
Changes:
- Upgrades the OKE cluster and node pool Kubernetes versions.
- Changes ARM image selection to derive the OKE image version dynamically from the cluster version.
- Makes the Autonomous Database ignore all subsequent Terraform-managed changes and removes a local helper script.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
iac/terraform/oke.tf |
Bumps OKE control plane and node pool Kubernetes versions. |
iac/terraform/images.tf |
Changes OKE ARM image selection to use the cluster version dynamically. |
iac/terraform/conv.py |
Removes a local script that generated a MySQL init shell script. |
iac/terraform/adb.tf |
Changes ADB lifecycle rules to ignore all drift/updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cluster_id = oci_containerengine_cluster.k8s_cluster.id | ||
| compartment_id = var.compartment_ocid | ||
| kubernetes_version = "v1.31.1" | ||
| kubernetes_version = "v1.35.2" |
| oke_arm_images = [ | ||
| for source in data.oci_containerengine_node_pool_option.oke_options.sources : | ||
| source if can(regex("Oracle-Linux.*aarch64.*OKE-1\\.31\\.1", source.source_name)) | ||
| source if can(regex(format("Oracle-Linux.*aarch64.*OKE-%s", replace(oci_containerengine_cluster.k8s_cluster.kubernetes_version, "v", "")), source.source_name)) |
|
|
||
| lifecycle { | ||
| prevent_destroy = true | ||
| ignore_changes = all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.