fix(client): add Accept: application/json header to all generated fetch requests#290
Merged
Merged
Conversation
…ch requests Servers that content-negotiate (Laravel, Rails, Django REST Framework) return HTML or redirects instead of JSON error bodies when no Accept header is sent. The new emitAcceptHeader helper inserts 'Accept': 'application/json' as the first entry in both _request and _requestForm headers blocks, before ...headers so callers can still override the header via the config field.
Contributor
Fallow audit reportFound 2 findings. Details
Generated by fallow. |
Contributor
Fallow audit report0 inline findings selected for GitHub review. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #289
The generated fetch client was omitting
Accept: application/jsonfrom all requests. In a browser, the defaultAccept: text/html,...header was sent, causing server frameworks that perform content-negotiation (Laravel, Rails, Django REST Framework, etc.) to return HTML or redirect responses instead of JSON error bodies.'Accept': 'application/json'as the first default header in both_requestand_requestFormgenerated helpers...headersspread so users can override it via theheadersconfig fieldContent-Type: application/jsonbehaviour for request bodiesTest plan
Accept: application/jsonand returns JSON error bodies