chore: fix fallow dead-code false positives for docs site#43
Merged
Conversation
fallow flagged docs/src/components/Footer.astro and docs/src/styles/custom.css as unused files. Both are reachable, just through Starlight config strings (components.Footer override and customCss) in docs/astro.config.mjs that fallow's static analysis cannot trace. Declare them as fallow entry points so they are correctly treated as reachable instead of deleting working files. Also ignore docs/dist/** build output for scan hygiene. dead-code: 2 issues -> 0.
Contributor
Fallow audit reportNo GitHub PR/MR findings. Generated by fallow. |
Contributor
Fallow audit report0 inline findings selected for GitHub review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the 2 fallow
dead-code(unused-files) findings:docs/src/components/Footer.astrodocs/src/styles/custom.cssWhy these are false positives
Both files ARE used by the docs site, but only through Starlight config strings in
docs/astro.config.mjsthat fallow's static analysis cannot follow:components.Footer: './src/components/Footer.astro'(line 90)customCss: ['./src/styles/custom.css'](line 88)Deleting them would break the docs footer override and custom styling. The correct fix is to declare them as fallow
entrypoints so they are treated as reachable.Change
entryfor the two Starlight-referenced files.docs/dist/**toignorePatterns(scan hygiene for built output).CLAUDE.mdand shipped package unaffected.Result
fallowdead-code: 2 issues -> 0. Changed-file audit clean.Note: the remaining
dupes(clone groups in the multi-variant writer/parser) andhealthhotspots are advisory and pre-existing; not addressed here (see PR discussion).