Skip to content

Repo hardening: fix install instructions, dead imports, hygiene#2

Open
cognis-digital wants to merge 3 commits into
mainfrom
cognis-audit/repo-hardening
Open

Repo hardening: fix install instructions, dead imports, hygiene#2
cognis-digital wants to merge 3 commits into
mainfrom
cognis-audit/repo-hardening

Conversation

@cognis-digital

@cognis-digital cognis-digital commented Jun 12, 2026

Copy link
Copy Markdown
Owner

This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:

  • fix 2 broken pip install line(s) in README (package is not on PyPI; use the working git+https install)
  • remove 5 unused import(s) (ruff F401/F811)

Each change is deterministic; all touched Python files were confirmed to still compile (py_compile) before this PR was opened.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR! 🚀 A maintainer will review under the collaboration-pull model (see CONTRIBUTING.md).

@cognis-digital cognis-digital force-pushed the cognis-audit/repo-hardening branch 2 times, most recently from 443b734 to eeece5d Compare June 13, 2026 12:42
Cognis Digital added 3 commits June 13, 2026 08:42
…rehensive cross-platform install scripts

- README opens with a plain-language "What is this?" overview
- comprehensive Install section + install.sh / install.ps1 (pipx / uv / pip git+https / source)
- verified build-out: real test + CLI audit embedded (README Verification + AUDIT.md)
- load_config: raise ValueError on malformed/non-object JSON, OSError on
  unreadable file; empty/whitespace-only files return {} cleanly
- load_baseline: raise OSError on unreadable file; validate 'fingerprints'
  is a list when reading object format
- write_baseline: wrap open() in try/except OSError with clear message
- Allowlist.from_iterables: raise ValueError with the pattern and re.error
  message when a user-supplied allowlist regex is invalid
- Engine.scan_path: raise FileNotFoundError immediately for a non-existent
  root rather than silently returning an empty list
- cli._build_engine: returns (engine, None) or (None, error_msg) so all
  callers print a clean error line to stderr and exit 1 instead of showing
  a raw traceback; validates --entropy-threshold >= 0; catches bad
  --allow-regex patterns before they reach re.compile
- cli._cmd_baseline: catch OSError from write_baseline
- cli.main: top-level try/except prints unexpected exceptions to stderr and
  returns EXIT_ERR; handles KeyboardInterrupt gracefully
- tests/test_harden.py: 20 new tests covering all of the above paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant