Repo hardening: fix install instructions, dead imports, hygiene#2
Open
cognis-digital wants to merge 3 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#2cognis-digital wants to merge 3 commits into
cognis-digital wants to merge 3 commits into
Conversation
443b734 to
eeece5d
Compare
added 3 commits
June 13, 2026 08:42
…rehensive cross-platform install scripts - README opens with a plain-language "What is this?" overview - comprehensive Install section + install.sh / install.ps1 (pipx / uv / pip git+https / source) - verified build-out: real test + CLI audit embedded (README Verification + AUDIT.md)
- load_config: raise ValueError on malformed/non-object JSON, OSError on
unreadable file; empty/whitespace-only files return {} cleanly
- load_baseline: raise OSError on unreadable file; validate 'fingerprints'
is a list when reading object format
- write_baseline: wrap open() in try/except OSError with clear message
- Allowlist.from_iterables: raise ValueError with the pattern and re.error
message when a user-supplied allowlist regex is invalid
- Engine.scan_path: raise FileNotFoundError immediately for a non-existent
root rather than silently returning an empty list
- cli._build_engine: returns (engine, None) or (None, error_msg) so all
callers print a clean error line to stderr and exit 1 instead of showing
a raw traceback; validates --entropy-threshold >= 0; catches bad
--allow-regex patterns before they reach re.compile
- cli._cmd_baseline: catch OSError from write_baseline
- cli.main: top-level try/except prints unexpected exceptions to stderr and
returns EXIT_ERR; handles KeyboardInterrupt gracefully
- tests/test_harden.py: 20 new tests covering all of the above paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.