Repo hardening: fix install instructions, dead imports, hygiene#1
Open
cognis-digital wants to merge 4 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#1cognis-digital wants to merge 4 commits into
cognis-digital wants to merge 4 commits into
Conversation
- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 4 unused import(s) (ruff F401/F811)
09fc0aa to
048c238
Compare
added 3 commits
June 13, 2026 08:20
…structions - Add TOOL_NAME and TOOL_VERSION constants to core.py (imported by __init__.py and required by the CLI; their absence broke all imports) - Rewrite top-level tests/test_smoke.py: the stale fixture imported a non- existent scan function; replace with real API tests that assert correct behaviour - Insert What is this layman overview in README via cognis:layman markers - Add comprehensive Install section and install.sh / install.ps1 scripts - All 25 tests green
- core: validate add_model() args (non-negative prices, positive context window, non-empty name); validate estimate() rejects negative input/output_tokens; guard count_tokens() against None input - cli: wrap _read_input() file open in try/except (exits 2 with clear message); validate --output-tokens >= 0 in count/budget; validate --max-cost and --max-tokens >= 0 in budget; guard _emit() against empty rows list - mcp_server: fix broken import of non-existent scan/to_json; expose tokenmeter_estimate() using the real estimate() API with error handling - webhook: validate URL scheme (http/https), guard empty stdin payload, split multiple imports on one line, add --timeout CLI flag - tests: 13 new tests covering missing file (exit 2), negative token args (exit 2), negative budget args (exit 2), None/empty to count_tokens, add_model validation errors, mcp_server importable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.