Support pattern-mode-only annotation runs#242
Open
frarentz wants to merge 1 commit into
Open
Conversation
…oceed when no entities are available by running pattern-mode diagram detect alone. Skip the standard diagram detect when the in-memory cache is empty, and fall back to the pattern job ID for finalize discoverability. FinalizeService now retrieves only pattern-mode results when the regular and pattern jobs are the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some projects, where there is no asset hierarchy, documents can be used to build this out. However, the current implementation fails if there no entities for matching. This PR adds support for pattern-match-only diagram detection.
Allow file annotation to proceed when no entities are available by running pattern-mode diagram detect alone. Skip the standard diagram detect when the in-memory cache is empty, and fall back to the pattern job ID for finalize discoverability. FinalizeService now retrieves only pattern-mode results when the regular and pattern jobs are the same.