Bugfix: Check if ColdboxVirtualApp Exists Before Shutdown #28
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you set `this.unLoadColdbox = true; ` in your tests, there won't be a `ColdboxVirtualApp` in the `request` scope and the page will throw an exception "The key [COLDBOXVIRTUALAPP] does not exist in the request scope, the structure is empty"
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the onRequestEnd method in the test harness throws an exception when this.unLoadColdbox = true is set in tests. The fix adds a defensive check to verify the existence of coldBoxVirtualApp in the request scope before attempting to call its shutdown method.
Changes:
- Added conditional check in
onRequestEndto prevent exception whencoldBoxVirtualAppis not in the request scope
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set
this.unLoadColdbox = true;in your tests, there won't be aColdboxVirtualAppin therequestscope and the page will throw an exception "The key [COLDBOXVIRTUALAPP] does not exist in the request scope, the structure is empty"Type of change
Checklist