Implementation with objects instead of arrays and speed tests to compare#2
Open
jdforsythe wants to merge 1 commit intocoldhead:masterfrom
Open
Implementation with objects instead of arrays and speed tests to compare#2jdforsythe wants to merge 1 commit intocoldhead:masterfrom
jdforsythe wants to merge 1 commit intocoldhead:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the file and created a new implementation using objects (with left and right properties) instead of arrays. I thought it was a fun exercise and was curious if the objects would outperform the arrays. The included test page shows (on my machine) a 0.5-1% speed advantage with arrays.
I simply plopped objects in and made zero performance tweaks.