Skip to content

Track HLevels of Sets and Theories#40

Open
mvr wants to merge 9 commits into
mainfrom
coln-compiler/hlevels
Open

Track HLevels of Sets and Theories#40
mvr wants to merge 9 commits into
mainfrom
coln-compiler/hlevels

Conversation

@mvr

@mvr mvr commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Split Level into Sort (Set/Theory) and HLevel (HProp/HSet).

I haven't looked into realms yet, so I don't know how this is supposed to interact with "EltOf" etc.

@mvr mvr requested a review from olynch June 18, 2026 16:38
Comment thread packages/coln-compiler/src/Coln/Core/Params.hs Outdated

@olynch olynch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks quite good.

What is the rational behind having a distinction between SetTheory and SetPropTheory? Maybe FunctionVariant should be a record of two things: SetTheory | TheoryTop and then the h-Level of the codomain.

This will also need to be rebased against ts-ffi-trunk, because that may have some changes to the Haskell. I will merge this in after ts-ffi-trunk is merged in.

Comment thread packages/coln-compiler/src/Coln/Core/Params.hs Outdated

@olynch olynch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll rebase and merge.

@olynch olynch force-pushed the coln-compiler/hlevels branch from a17ec09 to 28e6913 Compare June 23, 2026 16:07

@olynch olynch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mysterious failing test now

@github-actions

Copy link
Copy Markdown

Web demo preview: https://pr-40--coln-web-demo.netlify.app

@mvr mvr force-pushed the coln-compiler/hlevels branch from 26b4702 to 09fef4a Compare June 24, 2026 15:15
@mvr mvr requested a review from olynch June 24, 2026 15:29
@olynch olynch marked this pull request as ready for review June 24, 2026 15:35

@olynch olynch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change; I think we can drop PropTheoryU.

= PropU
| SetU
| TheoryU
| PropTheoryU -- TODO: better name?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could call this LawU, but also I can't think of a case where we would ever use this universe, so we don't need to put it in for now. A propositional theory can be encoded into TheoryU, and when it is decoded we still can know that it is propositional, because decode . code is the identity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants