Remove coln-ls license#70
Open
incipit0 wants to merge 3 commits into
Open
Conversation
|
Web demo preview: https://pr-70--coln-web-demo.netlify.app |
Contributor
|
Ah, I didn't notice this! You should remove this license file, and make sure that the copyright in the package.json or whatever is "Coln contributors" and then also that the license metadata in the package.json is |
d5ad437 to
36d320e
Compare
olynch
requested changes
Jun 24, 2026
| "private": true, | ||
| "author": "Coln contributors", | ||
| "type": "module", | ||
| "license": "(MIT OR Apache-2.0)", |
Contributor
There was a problem hiding this comment.
Just to be consistent, I've been doing Apache-2.0 OR MIT.
| "LICENSE-APACHE" | ||
| ], | ||
| "scripts": { | ||
| "copy-license": "cp ../../LICENSES/MIT.txt LICENSE-MIT && cp ../../LICENSES/Apache-2.0.txt LICENSE-APACHE", |
Contributor
There was a problem hiding this comment.
Do we need to copy the license files? Also, maybe just cp -r ../../LICENSES LICENSES?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I can remove a license since it is copyrighted by me?