fix: add ZEND_TRACK_ARENA_ALLOC on ext build option, clean-build-cache command#65
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds -DZEND_TRACK_ARENA_ALLOC to extension compilation flags for specialized test modes (debug/gcov/valgrind/msan/asan/ubsan) so the extension's macro usage matches the PHP runtime it links against, and introduces a new clean-build-cache command to remove built PHP runtimes and their cached copies.
Changes:
- Conditionally set
PSKEL_TRACK_ARENA_ALLOCincmd_testand append-DZEND_TRACK_ARENA_ALLOCtoCFLAGS/CPPFLAGSfor specialized builds. - Add
cmd_clean_build_cacheplus helpersremove_path_if_existsandremove_built_php_runtime, wired into usage and dispatch. - Document the new
clean-build-cachecommand inREADME.mdandREADME_ja.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pskel.sh | Adds arena-alloc tracking flag handling in cmd_test and a new clean-build-cache command with helpers. |
| README.md | Documents the new clean-build-cache command and realigns the command list. |
| README_ja.md | Mirrors the English doc update for clean-build-cache. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.