Skip to content

fix: add ZEND_TRACK_ARENA_ALLOC on ext build option, clean-build-cache command#65

Merged
zeriyoshi merged 2 commits into
mainfrom
fix_tracked_alloc_and_add_clean
May 28, 2026
Merged

fix: add ZEND_TRACK_ARENA_ALLOC on ext build option, clean-build-cache command#65
zeriyoshi merged 2 commits into
mainfrom
fix_tracked_alloc_and_add_clean

Conversation

@zeriyoshi
Copy link
Copy Markdown
Contributor

No description provided.

@zeriyoshi zeriyoshi self-assigned this May 28, 2026
Copilot AI review requested due to automatic review settings May 28, 2026 07:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds -DZEND_TRACK_ARENA_ALLOC to extension compilation flags for specialized test modes (debug/gcov/valgrind/msan/asan/ubsan) so the extension's macro usage matches the PHP runtime it links against, and introduces a new clean-build-cache command to remove built PHP runtimes and their cached copies.

Changes:

  • Conditionally set PSKEL_TRACK_ARENA_ALLOC in cmd_test and append -DZEND_TRACK_ARENA_ALLOC to CFLAGS/CPPFLAGS for specialized builds.
  • Add cmd_clean_build_cache plus helpers remove_path_if_exists and remove_built_php_runtime, wired into usage and dispatch.
  • Document the new clean-build-cache command in README.md and README_ja.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pskel.sh Adds arena-alloc tracking flag handling in cmd_test and a new clean-build-cache command with helpers.
README.md Documents the new clean-build-cache command and realigns the command list.
README_ja.md Mirrors the English doc update for clean-build-cache.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zeriyoshi zeriyoshi merged commit 31b648c into main May 28, 2026
119 checks passed
@zeriyoshi zeriyoshi deleted the fix_tracked_alloc_and_add_clean branch May 28, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants