[website] Fix horizontal scrolling on pages with tables#189
Open
DmitrySharabin wants to merge 2 commits intomainfrom
Open
[website] Fix horizontal scrolling on pages with tables#189DmitrySharabin wants to merge 2 commits intomainfrom
DmitrySharabin wants to merge 2 commits intomainfrom
Conversation
✅ Deploy Preview for color-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
This ...doesn't seem like the right solution. Ideally, these should not be rendered side by side if there's not enough space to render them side by side… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
To see it in action, follow this link: https://deploy-preview-189--color-elements.netlify.app/src/color-swatch/
Remaining issues
On tiny screens, there still might be overflows, causing horizontal scrolling. Like so:
I can think of one fix for this (and already tried it): add
overflow-x: autoto the slot nameddemoof thehtml-demoelement. To do so, we should probably make it a part (andtoolbarandcodeas well). This change is already a part of the element's roadmap, so it's a planned improvement.Adding
overflow-x: auto, though, might cause an issue with the details popup:I wonder if we should move the logic we use in
<color-chart>to overcome this limitation withoverflowto the<color-swatch>element itself and handle it there? In that case, the issue will be fixed in<color-swatch>and<color-chart>.