Skip to content

Adopt the new NudeElement API #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DmitrySharabin wants to merge 1 commit into from
Closed

Adopt the new NudeElement API #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/common/color-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,13 @@ const Self = class ColorElement extends NudeElement {
}
}

// CRITICAL: Initialize the class BEFORE defining the custom element.
// This ensures mixins are applied and composed functions are created
// on the prototype before the browser caches references to lifecycle callbacks.
// Without this, the browser would register the unmodified inherited callbacks
// from parent classes instead of the composed versions created by mixins.
this.init();

customElements.define(this.tagName, this);
}
};
Expand Down