Skip to content

refactor: remove readonly styling for input 🔄 #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramiAbdou merged 2 commits into from
Jul 23, 2025
Merged

refactor: remove readonly styling for input 🔄 #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
691cc3a
remove readonly stylign
ramiAbdou Jul 23, 2025
57ee0bf
remove isNew label
ramiAbdou Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/member-profile/app/routes/_profile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ export default function ProfileLayout() {
<Dashboard.NavigationLink
icon={<Users />}
label="Peer Help"
isNew
pathname={Route['/peer-help']}
prefetch="intent"
/>
Expand Down
8 changes: 1 addition & 7 deletions packages/ui/src/components/input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,16 +171,10 @@ function formatPhoneNumber(input: string): string {

// Helpers

type InputCnOptions = {
readOnly?: boolean;
};

export function getInputCn(options: InputCnOptions = { readOnly: true }) {
export function getInputCn() {
return cx(
'w-full rounded-lg border border-gray-300 p-2',
'disabled:cursor-not-allowed disabled:bg-gray-100 disabled:text-gray-500',
options.readOnly &&
'read-only:cursor-not-allowed read-only:bg-gray-50 read-only:text-gray-500',
'focus:border-primary'
);
}
2 changes: 1 addition & 1 deletion packages/ui/src/components/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function Select({
return (
<select
className={cx(
getInputCn({ readOnly: false }),
getInputCn(),

// If the width is set to 'fit', we'll add some padding to the right
// to allow room for the arrow icon to fit in the "background-image".
Expand Down