Skip to content

fix: batch the member removals and show loading state ⏳ #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramiAbdou merged 2 commits into from
Sep 23, 2025
Merged

fix: batch the member removals and show loading state ⏳ #880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
281b72c
submit button state
ramiAbdou Sep 23, 2025
ff77754
batch the removals
ramiAbdou Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 25 additions & 18 deletions apps/admin-dashboard/app/routes/_dashboard.students.remove.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
validateForm,
} from '@oyster/ui';
import { Callout } from '@oyster/ui/callout';
import { splitArray } from '@oyster/utils';

import { Route } from '@/shared/constants';
import {
Expand Down Expand Up @@ -66,23 +67,31 @@ export async function action({ request }: ActionFunctionArgs) {
}

async function removeMembers(ids: string[]): Promise<number> {
const students = await db
.deleteFrom('students')
.where('id', 'in', ids)
.returning(['airtableId', 'email', 'firstName', 'slackId'])
.execute();

for (const student of students) {
job('student.removed', {
airtableId: student.airtableId as string,
email: student.email,
firstName: student.firstName,
sendViolationEmail: false,
slackId: student.slackId,
});
const batches = splitArray(ids, 10);

let count = 0;

for (const batch of batches) {
const students = await db
.deleteFrom('students')
.where('id', 'in', batch)
.returning(['airtableId', 'email', 'firstName', 'slackId'])
.execute();

for (const student of students) {
job('student.removed', {
airtableId: student.airtableId as string,
email: student.email,
firstName: student.firstName,
sendViolationEmail: false,
slackId: student.slackId,
});
}

count += students.length;
}

return students.length;
return count;
}

export default function RemoveMembersPage() {
Expand Down Expand Up @@ -126,9 +135,7 @@ export default function RemoveMembersPage() {
</Field>

<Button.Group>
<Button color="error" type="submit">
Remove
</Button>
<Button.Submit color="error">Remove</Button.Submit>
</Button.Group>
</Form>
</Modal>
Expand Down