Skip to content

avoid frozen string#75

Open
espen wants to merge 1 commit intocomfy:masterfrom
espen:patch2
Open

avoid frozen string#75
espen wants to merge 1 commit intocomfy:masterfrom
espen:patch2

Conversation

@espen
Copy link

@espen espen commented Jan 19, 2025

Fixes #73

@dennispaagman
Copy link

hey @GBH 👋

In preparation to freeze all strings by default, Ruby is emitting deprecation warnings when strings are modified without explicitly marking them.

Here is som reading on the topic:

This PR (ty @espen 🙌) will fix those issues for this gem, making it future proof for future Ruby versions.

Are you willing to have a look at this? I'm not sure if you still feel like maintaining this gem as the last release was 7 years ago. The gem is still quite popular, so I think a lot people will run into this issue at some point with future Ruby versions.

If you want I can put in some time to get it up to date (testing against modern rubies and rails versions, for example). Let me know!

@raghubetina
Copy link

I updated for modern Rubies and Rails for my own use here; more than happy to contribute it back if it's of interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Ruby 3.4.0: warning: literal string will be frozen in the future

3 participants