Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
9183e8a
up and running before checks
michael-odonovan Apr 8, 2026
a4293f7
Empty commit to trigger build
michael-odonovan Apr 8, 2026
9d88de2
package messup
michael-odonovan Apr 8, 2026
a673e14
try pulling netlify config in this repo
michael-odonovan Apr 8, 2026
7ca323b
vite build fix
michael-odonovan May 2, 2026
ce1cb08
playwright config adjustments
michael-odonovan May 2, 2026
7ccc85d
package.json script adjustments
michael-odonovan May 2, 2026
9831cb2
adjust tests
michael-odonovan May 2, 2026
45b091d
playwright url issue
michael-odonovan May 2, 2026
21e4494
dist folder fix
michael-odonovan May 2, 2026
070131c
Merge branch 'master' into 4973_CL_rebuild
michael-odonovan May 2, 2026
e05d40c
snaps
michael-odonovan May 2, 2026
282edf6
fixing playwright
michael-odonovan May 6, 2026
365fa40
reorder exported components into alphabetical order
michael-odonovan May 6, 2026
c686869
bank some work
michael-odonovan May 6, 2026
d60e648
fix implied & issue for Checkbox
michael-odonovan May 6, 2026
6f98b16
errant example delete
michael-odonovan May 6, 2026
ab48fea
Atom checks
michael-odonovan May 7, 2026
e4fd083
lint
michael-odonovan May 7, 2026
c70a346
Checking Atoms and finsessing layout
michael-odonovan May 8, 2026
1a6f469
package clean up
michael-odonovan May 8, 2026
066461d
snaps
michael-odonovan May 8, 2026
b65f966
more fixes
michael-odonovan May 8, 2026
e6b086d
cleanup and reimport playwright files
michael-odonovan May 8, 2026
0b209ea
more wrapper sorting
michael-odonovan May 8, 2026
baed1c2
fix Membership example
michael-odonovan May 8, 2026
f4b012a
test fixes
michael-odonovan May 8, 2026
ec41f98
test fixes - molecules and organisms
michael-odonovan May 11, 2026
efc74e2
test fixes
michael-odonovan May 12, 2026
17623fe
test fix
michael-odonovan May 13, 2026
8e06ce2
another fix try
michael-odonovan May 14, 2026
14a30bd
adjustments for running locally
michael-odonovan May 15, 2026
0049611
update some README notes
michael-odonovan May 15, 2026
c6b020c
revert playwright tests
michael-odonovan May 15, 2026
8f2487a
Atoms tests passing locally
michael-odonovan May 15, 2026
aa56be0
downgrade start-server-and-test
michael-odonovan May 15, 2026
2f6d8e7
fix start-server dependency
michael-odonovan May 15, 2026
1857271
update scripts and remove unneeded package
michael-odonovan May 15, 2026
f85edae
playwright fixes
michael-odonovan May 18, 2026
289d9f0
diff check and dynamicGalleries clear
michael-odonovan May 18, 2026
2e93757
Organisms good
michael-odonovan May 18, 2026
90c27c3
snaps
michael-odonovan May 18, 2026
cad8c35
Merge branch 'master' into 4973_CL_rebuild
michael-odonovan May 19, 2026
4453f62
UX tweaks and remote test fail
michael-odonovan May 20, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"react/jsx-filename-extension": "off",
"react/no-danger": "off",
"import/no-extraneous-dependencies": ["error", {"devDependencies": ["importers/**/*.js"]}],
"react/jsx-curly-newline": "off", // already handled by prettier, but differently, so we have to disable one
"react/jsx-curly-newline": "off",
"quotes": [
2,
"single",
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.20.0
v18.20.0
15 changes: 14 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,20 @@ Comic Relief React Component Library
[![GitHub Actions](https://github.com/comicrelief/component-library/actions/workflows/main.yml/badge.svg)](https://github.com/comicrelief/component-library/actions)
[![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)

React components to be shared across Comic Relief applications



# Rebuild notes:
### All diffs in main exported files are non-functional:
- Styled-components & syntax updates => CSS output is identical, issues are around assumed "&" in nested CSS.
- Confetti updated to newer react-canvas-confetti API => new prop names to activate confetti.
- _TriggerConfetti.js removed => was likely a private helper no longer needed.

### Have added a couple of scripts I worked on to make deving playwright locally less insanity inducing.



# React components to be shared across Comic Relief applications

### Use

Expand Down
8 changes: 5 additions & 3 deletions babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@
module.exports = function (api) {
api.cache(true);

const presets = [['react-app', { absoluteRuntime: false }]];
const presets = [
['@babel/preset-env', { targets: { node: 'current' } }],
['@babel/preset-react', { runtime: 'automatic' }]
];
const plugins = [
['babel-plugin-styled-components'],
['import', { libraryName: 'lodash', libraryDirectory: '', camel2DashComponentName: false }]
['babel-plugin-styled-components']
];

return {
Expand Down
131 changes: 131 additions & 0 deletions component-checks-Atoms.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@

### Notes:
- styled-components v6 the "&" in "&:hover" is no longer implicit
- haven't replaced axios remember...

# Gotchas:
- new prop names for confetti usage no needed in CR.com


## Atoms

- [ ] AmbientVideo
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] Button
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [ ] code manual lint

- [ ] ButtonWithStates
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] Checkbox
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] Confetti
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] ErrorText
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] InfoMessage
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] Input
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] Label
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] Link
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] Logo
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] Pagination
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] Picture
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] RadioButton
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] RichText
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] Select
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [X] SocialIcons
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] Text
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] TextArea
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

- [ ] TextInputWithDropdown
- [X] Diff check
- [X] Visual check of dev server
- [X] Example functionality check
- [X] code manual lint

169 changes: 169 additions & 0 deletions component-checks-Molecules.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,169 @@

### Notes:
- styled-components v6 the "&" in "&:hover" is no longer implicit
- removing Axios as conflict

## Molecules

- [ ] Accordion
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] ArticleTeaser
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] Banner
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] Box
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] Card
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] CardDs
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] Chip
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] Countdown
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] CTAMultiCard
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] CTASingleCard
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] Descriptor
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] DoubleCopy
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] HeroBanner
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] InfoBanner
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] Lookup
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] PartnerLink
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] Promo
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] QuoteSlice
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] SchoolLookup
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] SearchInput
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] SearchResult
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] ShareButton
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] SimpleSchoolLookup
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] SingleMessage
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] SingleMessageDs
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] Typeahead
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

- [ ] VideoBanner
- [ ] Diff check
- [ ] Visual check of dev server
- [ ] Example functionality check
- [ ] code manual lint

Loading
Loading