fix: Removes margin from the accordion's chevron#885
Merged
Conversation
AndyEPhipps
reviewed
May 18, 2026
Contributor
AndyEPhipps
left a comment
AndyEPhipps
left a comment
There was a problem hiding this comment.
Have you tested this commit in a local CRcom to confirm it's enough to solve the issue? Just preempting any additional to-and-froing
…s which adds a bottom margin
Contributor
Author
|
Good shout because when I did this last thing Friday, I stepped away to do dinner or something with the intention of coming back to make that check - did I do that? I did not. |
AndyEPhipps
approved these changes
May 18, 2026
|
🎉 This PR is included in version 8.73.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
@curlyfriesplease I'll bring this via my CRcom PR, presuming there's no tweaks that need to be made there for this work? |
Contributor
Author
|
@AndyEPhipps yep, nothing require there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
Once the accordion gets used in the frontend, there's some default img style somewhere applying a margin we don't want, to the accordion's chevron.
This
margin: 0should prevent that and allow it to stay the size we want.Why is this required?
Bugfix
link to Jira ticket:
ENG-5083
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...