ci: perltidy the test suite to satisfy the pgperltidy check#21
Merged
Conversation
The pgperltidy half of the "Check" CI job was red because 27 test files predated (or were not run through) perltidy. Reformat them with the project profile (src/tools/pgindent/perltidyrc, perltidy v20250105, the version CI uses) so the check passes. Formatting only: every change is whitespace/line-wrapping and the token stream of each file is unchanged. A sample of the reformatted tests still passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The multi-line trailing comment on OPEN_PG_TDE_WAL_KEY_FILE_MAGIC sat at a deep indentation where it ran past the line-length limit, so the pgindent check wanted to rewrap it. Move the rationale into the block comment above the defines and shorten the trailing comments, which is clearer and keeps them well under the column limit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Follow-up: one comment line reached 80 columns; reword so every line is under 78.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pgperltidy half of the "Check" CI job has been red on
mainand every PR because 27 test files were never run through perltidy. With pgindent now stabilized (#18), perltidy is the only thing keeping the Check job red.This reformats those 27 files with the project profile (
src/tools/pgindent/perltidyrc) using perltidy v20250105, the version the CI uses, sorun-pgperltidy.sh --assert-tidypasses.Safety
basic,tde_heap,wal_encrypt,rotate_key,unlogged_tables) still passes under the meson harness.perltidy --assert-tidypasses on the full enumerated perl file set after the change.No test logic changes.
🤖 Generated with Claude Code