Open
Conversation
Contributor
|
This is a good idea. However, it looks incomplete. The generate script also creates a postal_code_example for subdivisions, but the subdivision json files weren't updated, and neither was Subdivision.php |
bojanz
reviewed
May 31, 2019
src/AddressFormat/AddressFormat.php
Outdated
| * This is an example postal code used to provide additional context to the | ||
| * end-user. It can be displayed as a placeholder, field description or as | ||
| * part of the validation. | ||
| * (E.g. Zip code 12345 is not valid for Louisana (Example: 70001). |
Contributor
There was a problem hiding this comment.
Sentence starts with a parenthesis, but doesn't end with one. I suggest just leaving out the first one and starting with just "E.g."
Author
There was a problem hiding this comment.
Thanks for the feedback. I've addressed this in 7cb62ca
Author
|
Included subdivisions resources and added postal_code_example to both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem/Motivation
There are many scenarios in which the postal code validation return ambiguous error messages. It might be useful to provide some additional context through a valid example. Google provides a list of valid postal code examples under the
zipexproperty. As a first step to improve postal code validation, we would need to include this property in the addressing resources.generate_address_data.phpto includezipexon both country and subdivision levelpostalCodeExampleand getter toAddressFormatclassCloses #127