Skip to content

Implement private read receipts and typing indicators#748

Merged
Airyzz merged 6 commits intocommetchat:mainfrom
Grafcube:private-rr
Feb 28, 2026
Merged

Implement private read receipts and typing indicators#748
Airyzz merged 6 commits intocommetchat:mainfrom
Grafcube:private-rr

Conversation

@Grafcube
Copy link
Contributor

Includes options for room specific overrides. The benefit of this implementation is that you can have different preferences for different accounts and those settings are restored on new devices.

I am very inexperienced with Flutter so there may be mistakes.

Fixes #456
Fixes #645

Screenshots

Global preferences:

image

Room overrides:

image

@Grafcube Grafcube force-pushed the private-rr branch 2 times, most recently from dd742d3 to 0395c38 Compare February 24, 2026 05:54
Copy link
Contributor

@Airyzz Airyzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks like a great addition, but needs some changes in how its implemented.

The biggest issue to me is that there is a lot of repeated code around getting and parsing settings from account data. Instead, I'd suggest adding the following to ReadReceiptComponent and TypingIndicatorComponent

// ReadReceiptComponent
bool get usePublicReadReceipts;
bool usePublicReadReceiptsForRoom(Room room);
Future<void> setUsePublicReadReceipts(bool value);
Future<void> setUsePublicReadReceiptsForRoom(Room room, bool value);
// TypingIndicatorComponent
bool get typingIndicatorsEnabled;
bool typingIndicatorsEnabledForRoom(Room room);
Future<void> setTypingIndicatorsEnabled(bool value);
Future<void> setTypingIndicatorsEnabledForRoom(Room room, bool value);

And then just accessing these throughout the app instead.

Let me know if you have any questions!

Includes options for room specific overrides.

Fixes commetchat#456
Fixes commetchat#645
@Grafcube
Copy link
Contributor Author

I have made all the requested changes

@Grafcube Grafcube requested a review from Airyzz February 25, 2026 15:05
Airyzz
Airyzz previously approved these changes Feb 27, 2026
Copy link
Contributor

@Airyzz Airyzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks much better now! I made a few small tweaks, mostly just UI things and changing the wording on some text. Let me know if you have any problem with those changes, otherwise I think this is good to merge

@Grafcube
Copy link
Contributor Author

Looks good 👍 I also think it's good to go now.

@Airyzz Airyzz merged commit 18f893b into commetchat:main Feb 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Hide your read receipts Support hidden read receipts and hidden typing indicators

2 participants