Skip to content

Load schemas before calling print_deps#1766

Merged
mr-c merged 1 commit intomainfrom
load-schemas-before-print_deps
Mar 15, 2026
Merged

Load schemas before calling print_deps#1766
mr-c merged 1 commit intomainfrom
load-schemas-before-print_deps

Conversation

@kinow
Copy link
Member

@kinow kinow commented Nov 18, 2022

Closes #1765

Unit test fails for main, and passes on this branch. The command from the issue reported also passes on this branch.

Cheers,
-Bruno

@kinow kinow force-pushed the load-schemas-before-print_deps branch 3 times, most recently from 9792f84 to 2e5cc2e Compare November 18, 2022 23:36
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.10%. Comparing base (5bd0edc) to head (8f29d0b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1766       +/-   ##
===========================================
+ Coverage   55.23%   85.10%   +29.87%     
===========================================
  Files          46       46               
  Lines        8522     8522               
  Branches     1988     1988               
===========================================
+ Hits         4707     7253     +2546     
+ Misses       3316      802     -2514     
+ Partials      499      467       -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kinow
Copy link
Member Author

kinow commented Nov 19, 2022

Hmmm, curious. I saw the tests failing, they are on the same test file that I used.

I picked the first test that failed for me, test_examples.py, test_trick_scandeps. I can confirm the command tested works on main, and fails on my branch.

However, cwltool --validate $file fails on both main and on this branch. So should a CWL file that fails validation, still be used on a unit test? The file is https://github.com/common-workflow-language/cwltool/blob/67a180835c001906cff4086963cd00ee99893498/tests/wf/trick_defaults.cwl

If so I will dig into the issue more and try to extract the part that loads the schemas from the resolve_and_validate_document function 👍

@mr-c mr-c force-pushed the load-schemas-before-print_deps branch 2 times, most recently from d7d3c4e to c5c247f Compare March 15, 2026 10:58
Small modifications to other tests:
1. `baseCommand: true` is invalid CWL, and unrelated to the scandep bugs
   that are being tested
2. for the content_types test, choose a different URL to avoid
   "429 Client Error: Too Many Requests for url"

Co-authored-by: Michael R. Crusoe <michael.crusoe@gmail.com>
@mr-c mr-c force-pushed the load-schemas-before-print_deps branch from c5c247f to 8f29d0b Compare March 15, 2026 11:16
@mr-c mr-c enabled auto-merge (rebase) March 15, 2026 11:21
@mr-c mr-c merged commit 4c8e609 into main Mar 15, 2026
78 of 84 checks passed
@mr-c mr-c deleted the load-schemas-before-print_deps branch March 15, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cwltool --print-deps fails with workflows having namespaced location steps

2 participants