fix: ensure CI releases new versions to NPM#53
Open
igor9silva wants to merge 1 commit intocommonbaseapp:mainfrom
Open
fix: ensure CI releases new versions to NPM#53igor9silva wants to merge 1 commit intocommonbaseapp:mainfrom
igor9silva wants to merge 1 commit intocommonbaseapp:mainfrom
Conversation
Collaborator
|
thanks for looking into it and sorry for the late response. Does that mean it also bumps when we update docs or the demo? |
Author
|
Hi @Gregoor, yes. I personally don't see that as an issue. Completely fine to bump a patch version in the case of updated docs. Otherwise we'll have to make sure all merged commits follow the semantic-release conventions. Alternatively, I could do a check step on PRs to guarantee it follows the convention. This would block non-confirming PRs from being merged, which I'm not a big fan of, but it's your call. Let me know if I should update this. |
Collaborator
|
Yeah for me that would be an issue, would not want to push empty updates onto our users. We already use husky to lint commits to follow semvar conventions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the last merged PR (#50), it looks like the release job did run, but the specific
pnpm publishstep was skipped.This repo uses go-semantic-release to compute the new version bump, which relies on the commit messages to decide between a patch, minor or major bump.
Likely due to the PR merge having squashed commits,
sematic-releasesays "no new version" and we end up with no deployment.This change forces it to always do at least a patch bump.