Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a dedicated read-replica database connection for expensive geocode lookups and tweaks default map configuration for an example organisation map.
Changes:
- Add a second Kysely instance (
dbRead) backed by a read-replicapgpool, sharing the existing plugin stack. - Switch the expensive
findAreasByPointquery to use the read replica while keeping other queries on the primary. - Update the example organisation map view to use a default calculation type and explicitly enable the choropleth layer.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/server/services/database/index.ts |
Defines a read-replica Pool, corresponding PostgresDialect, shared plugin list, and exports a new dbRead Kysely instance alongside the existing db. |
src/server/repositories/Area.ts |
Updates findAreasByPoint to run against dbRead instead of db to offload this heavy spatial read from the primary. |
src/server/commands/ensureOrganisationMap.ts |
Uses DEFAULT_CALCULATION_TYPE for the map view’s calculationType and explicitly sets showChoropleth: true in the created example view config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.