Fix #5711 Incorrect rotation in Edit Image while uploading.

[acemarco1311]

Description (required)

Fixes #5711. While uploading, when click "Edit Image" and then perform no rotation (click Save, or click Rotate 4 times to get back to the original position and Save), the image will be automatically rotated 90 degrees.

What changes did you make and why?
Change rotateImage() function implementation in edit/TransformImageImpl.kt. When the given degree is not expected (e.g 0), the transformation of the image should be default instead of rotating 90 degree (LLJTran.ROT_90).

Tests performed (required)

Tested on Pixel 8 with API level 35.

Reproduce:

1. Open app.
2. Upload image.
3. Click "Edit Image".
4. Click "Save" or "Rotate" 4 times so that the image will be in the original position then "Save".

Error Behavior:

error_final.mp4

Expected Behavior:
The image will be shown as original instead of being rotated 90 degree after clicking "Save".

Screenshots (for UI changes only)

expected_final.mp4

---

[nicolas-raoul]

Hi Toan,

Would you mind checking whether your change works with all JPGs at https://github.com/recurser/exif-orientation-examples ?

Thanks! 🙂

I feel like different pictures have different properties, and what works for one picture might not work for another.

Idea potentially for another pull request:
It would be great if we had a small repository (could be a Google Drive for now) with the example pictures we encountered so far, if the repository above is not enough. Ideally unit tests would use these pictures (or simpler+smaller JPGs) to check rotation in the UI and in the resulting image output.

[mnalis]

Yeah, it seems buggy (unless I messed up compilation). I've tried to build this PR against master (beta APK available at https://github.com/mnalis/apps-android-commons/actions/runs/13313689246). There seems to be at least one additional issue:

For example, this image has physical layout correct (landscape), but contains EXIF Orientation : Rotate 90 CW which orients it wrongly (to portrait).

• If you look it in gallery, EXIF orientation is applied, and it looks wrong in portrait (but behaviour is correct)
• If you share it in Commons app, EXIF orientation is applied, and it looks wrong in portrait (but behaviour is correct)
• but if you press Edit in Commons app, even before any rotate button is pressed, the picture is shown in landscape (so it looks good), but that means that EXIF orientation was ignored, which is wrong behaviour! It should be displayed in portrait too, before user starts to correct it with rotate buttons.
• also, if you for example rotate by 180, and save, and then press edit again, it will be shown in original non-rotated state. It seems that it completely ignores any existing rotation state of the picture when it is opened for edit.

[mnalis]

@acemarco1311 do you any idea why the PR does not (fully) solve the rotation issue? Do you intend to continue working on this PR?

[Kota-Jagadeesh]

@nicolas-raoul this is fixed as part of issue #5711 and the related commennt is : #6642 (comment)

[nicolas-raoul]

@Kota-Jagadeesh Thanks!

@mnalis By any chance if you have time, would you mind checking? :-)