Fix/external upload limit#6556
Closed
Kota-Jagadeesh wants to merge 23 commits intocommons-app:mainfrom
Closed
Conversation
RitikaPahwa4444
requested changes
Nov 9, 2025
Closed
Collaborator
Author
|
@nicolas-raoul @RitikaPahwa4444 Any update on this PR ? |
Collaborator
Author
|
Hi @nicolas-raoul, just checking in to see if this PR is still under review. Please let me know whenever you have time if there’s anything I should update or change. Thanks! |
Member
|
Sorry I am super busy this start of year, hopefully someone else can review? 😥 |
Collaborator
Author
|
No worries at all @nicolas-raoul, totally understand 😊 |
|
✅ Generated APK variants! |
Collaborator
Author
|
@nicolas-raoul Closing this PR as the issue is fixed in my updated PR #6689 along with issue #3101 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version is enhanced from the initial proposal (#6555) and includes key refactorings:
A non-blocking toast is shown to the user informing them that only the first 20 files were loaded, ensuring workflow continuity with clear feedback.
Both UploadActivity.kt and CustomSelectorActivity.kt now correctly reference this centralized constant, improving code maintainability and adherence to DRY principles.