fix: prevent TransactionTooLargeException by removing large list save…#6641
Open
Inuth0603 wants to merge 1 commit intocommons-app:mainfrom
Open
fix: prevent TransactionTooLargeException by removing large list save…#6641Inuth0603 wants to merge 1 commit intocommons-app:mainfrom
Inuth0603 wants to merge 1 commit intocommons-app:mainfrom
Conversation
|
✅ Generated APK variants! |
Collaborator
|
@Inuth0603 Thanks for contributing, will review this PR today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6639
What changes did you make and why?
This PR fixes the
TransactionTooLargeExceptioncrash that occurred when the app was backgrounded and resumed.Root Cause:
Fragment state (
android:support:fragments) was ~530KB, exceeding Android's safe transaction limit. This was caused by saving large lists (uploadMediaDetailAdapter.items) directly into the Bundle inonSaveInstanceState.Changes:
putParcelableArrayListforUPLOAD_MEDIA_DETAILSinUploadMediaDetailFragment.onSaveInstanceStateputParcelableArrayListforLIST_OF_DESCRIPTION_AND_CAPTIONinDescriptionEditActivity.onSaveInstanceStateDescriptionEditActivityto fall back to intent bundle if savedInstanceState doesn't have the listTrade-off:
On process death (rare), users may need to re-enter description/caption data. This is acceptable compared to a crash.
Tests performed