Skip to content

Fix: Warning dialog reappears after configuration change despite user dismissal #6799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Roniscend wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −2
Open

Fix: Warning dialog reappears after configuration change despite user dismissal #6799

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8693d00
Fix:Warning
Roniscend Mar 24, 2026
72b41ee
Merge branch 'main' into Warningagain
RitikaPahwa4444 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions app/src/main/java/fr/free/nrw/commons/WelcomeActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,17 @@ import fr.free.nrw.commons.utils.ConfigUtils.isBetaFlavour
class WelcomeActivity : BaseActivity() {
private var binding: ActivityWelcomeBinding? = null
private var isQuiz = false

private var isWarningDialogDismissed = false
/**
* Initialises exiting fields and dependencies
*
* @param savedInstanceState WelcomeActivity bundled data
*/
public override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
if (savedInstanceState != null) {
isWarningDialogDismissed = savedInstanceState.getBoolean("warning_dismissed", false)
}
Comment thread
Roniscend marked this conversation as resolved.
binding = ActivityWelcomeBinding.inflate(layoutInflater)
applyEdgeToEdgeAllInsets(binding!!.welcomePager.rootView)
setContentView(binding!!.root)
Expand All @@ -32,6 +35,7 @@ class WelcomeActivity : BaseActivity() {
// Enable skip button if beta flavor
if (isBetaFlavour) {
binding!!.finishTutorialButton.visibility = View.VISIBLE
if (!isWarningDialogDismissed) {

val copyrightBinding = PopupForCopyrightBinding.inflate(layoutInflater)

Expand All @@ -41,14 +45,20 @@ class WelcomeActivity : BaseActivity() {
.create()
dialog.show()

copyrightBinding.buttonOk.setOnClickListener { v: View? -> dialog.dismiss() }
copyrightBinding.buttonOk.setOnClickListener { v: View? -> dialog.dismiss()
isWarningDialogDismissed = true}
Comment thread
Roniscend marked this conversation as resolved.
}
}

val adapter = WelcomePagerAdapter()
binding!!.welcomePager.adapter = adapter
binding!!.welcomePagerIndicator.setViewPager(binding!!.welcomePager)
binding!!.finishTutorialButton.setOnClickListener { v: View? -> finishTutorial() }
}
override fun onSaveInstanceState(outState: Bundle) {
super.onSaveInstanceState(outState)
outState.putBoolean("warning_dismissed", isWarningDialogDismissed)
}
Comment thread
Roniscend marked this conversation as resolved.

public override fun onDestroy() {
if (isQuiz) {
Expand Down
Loading