Refactor: Migrate About screen UI from XML to Jetpack Compose#6803
Refactor: Migrate About screen UI from XML to Jetpack Compose#6803Roniscend wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Migrates the app’s About screen from an XML/ViewBinding implementation to a Jetpack Compose UI, as part of the broader Compose migration effort (#6629).
Changes:
- Replaces AboutActivity’s XML/ViewBinding layout with a Compose
setContent { ... }entry point. - Introduces a new Compose
AboutScreenwith top app bar, HTML-rendered sections, external links, and a translation language picker dialog. - Adds a basic Compose Material3 theme (
CommonsAppTheme) and custom color definitions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| app/src/main/java/fr/free/nrw/commons/theme/Theme.kt | Adds a Compose Material3 theme wrapper used by the new About screen. |
| app/src/main/java/fr/free/nrw/commons/theme/Color.kt | Introduces hard-coded colors for the Compose theme. |
| app/src/main/java/fr/free/nrw/commons/AboutScreen.kt | New Compose UI for the About screen, including HTML blocks and Translate dialog. |
| app/src/main/java/fr/free/nrw/commons/AboutActivity.kt | Refactors AboutActivity to host the Compose AboutScreen and moves actions to callbacks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Roniscend
force-pushed
the
AboutActivity
branch
from
917cad4 to
1574f8c
Compare
Signed-off-by: Owm Dubey <owmdubey163@gmail.com>
Roniscend
force-pushed
the
AboutActivity
branch
from
1574f8c to
584e9a6
Compare
|
✅ Generated APK variants! |
|
@nicolas-raoul , @neeldoshii can you please review this pr and suggest changes if any |
|
Sure. |
|
Seems like this PR is a duplicate of #6791. Could you please mention which file you are planning to pick from the referenced issue before starting work in the future? It would help avoid any duplication of effort. :-) |
Apologies, I did not notice that another PR had already been opened that is my mistake. Whichever you feel is better, you can merge it. Thanks a lot! |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Closing as this is a duplicate. But @Roniscend we would love to see your review and insights on the other PR :) |
Description (required)
Addresses #6629 Replaced XML-based About screen with Jetpack Compose implementation for improved UI consistency and maintainability.
The reason i chose About Screen first since it is entirely a simple vertical list of TextView and ImageView elements (Credits, License, Links)
Tests performed (required)
Tested 6.4.0-debug on Pixel 9(Android 16)
Screenshots (for UI changes only)
Before
Light mode
Dark Mode
After
Light Mode
Dark Mode