Skip to content

Nearby: prevent multiple offline snackbars from showing during map scroll #6808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akul-Tyagi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Nearby: prevent multiple offline snackbars from showing during map scroll #6808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ class NearbyParentFragment : CommonsDaggerSupportFragment(),
private var broadcastReceiver: BroadcastReceiver? = null
private var isNetworkErrorOccurred = false
private var snackbar: Snackbar? = null
private var hasShownOfflinePinsMessage = false
private var view: View? = null
private var scope: LifecycleCoroutineScope? = null
private var presenter: NearbyParentFragmentPresenter? = null
Expand Down Expand Up @@ -1291,12 +1292,14 @@ class NearbyParentFragment : CommonsDaggerSupportFragment(),
snackbar!!.dismiss()
snackbar = null
}
hasShownOfflinePinsMessage = false
} else {
if (snackbar == null) {
snackbar = Snackbar.make(
view!!, fr.free.nrw.commons.R.string.no_internet,
Snackbar.LENGTH_INDEFINITE
)
hasShownOfflinePinsMessage = false
searchable = false
setProgressBarVisibility(false)
}
Expand All @@ -1318,10 +1321,10 @@ class NearbyParentFragment : CommonsDaggerSupportFragment(),
if (!isNetworkErrorOccurred || snackbar == null) {
return
}
if (offlinePinsShown) {
// Avoid flickering between offline messages while panning; switch once per offline session.
if (offlinePinsShown && !hasShownOfflinePinsMessage) {
snackbar!!.setText(fr.free.nrw.commons.R.string.nearby_showing_pins_offline)
} else {
snackbar!!.setText(fr.free.nrw.commons.R.string.no_internet)
hasShownOfflinePinsMessage = true
}
}

Expand Down
Loading