Migrate from Fresco and Glide to Coil for image loading

app/build.gradle.kts

@@ -216,15 +216,15 @@ dependencies {
     // Utils
     implementation(libs.gson)
     implementation(libs.okhttp)
+    implementation(libs.coil)
+    implementation(libs.coil.network.okhttp)
     implementation(libs.retrofit)
     implementation(libs.retrofit.converter.gson)
     implementation(libs.retrofit.adapter.rxjava)
     implementation(libs.rxandroid)
     implementation(libs.rxjava)
     implementation(libs.rxbinding)
     implementation(libs.rxbinding.appcompat)
-    implementation(libs.facebook.fresco)
-    implementation(libs.facebook.fresco.middleware)
     implementation(libs.apache.commons.lang3)
 
     // UI
@@ -299,7 +299,6 @@ dependencies {
     testImplementation(libs.androidx.core.testing)
     testImplementation(libs.junit.jupiter.api)
     testRuntimeOnly(libs.junit.jupiter.engine)
-    testImplementation(libs.soloader)
     testImplementation(libs.kotlinx.coroutines.test)
     debugImplementation(libs.androidx.fragment.testing)
     testImplementation(libs.commons.io)
@@ -349,9 +348,6 @@ dependencies {
     implementation(libs.kotlinx.coroutines.rx2)
     testImplementation(libs.androidx.work.testing)
 
-    //Glide
-    implementation(libs.glide)
-    annotationProcessor(libs.glide.compiler)
     kaptTest(libs.androidx.databinding.compiler)
     kaptAndroidTest(libs.androidx.databinding.compiler)
 

app/src/main/java/fr/free/nrw/commons/CommonsApplication.kt

@@ -11,8 +11,17 @@ import android.os.Build
 import android.os.Process
 import android.util.Log
 import androidx.multidex.MultiDexApplication
-import com.facebook.drawee.backends.pipeline.Fresco
-import com.facebook.imagepipeline.core.ImagePipelineConfig
+import coil3.ImageLoader
+import coil3.request.crossfade
+import coil3.SingletonImageLoader
+import coil3.disk.DiskCache
+import coil3.memory.MemoryCache
+import coil3.network.okhttp.OkHttpNetworkFetcherFactory
+import coil3.intercept.Interceptor as CoilInterceptor
+import coil3.request.ErrorResult
+import coil3.request.ImageResult
+import okhttp3.OkHttpClient
+import okio.Path.Companion.toPath
 import fr.free.nrw.commons.auth.LoginActivity
 import fr.free.nrw.commons.auth.SessionManager
 import fr.free.nrw.commons.bookmarks.items.BookmarkItemsTable
@@ -28,7 +37,6 @@ import fr.free.nrw.commons.kvstore.JsonKvStore
 import fr.free.nrw.commons.language.AppLanguageLookUpTable
 import fr.free.nrw.commons.logging.FileLoggingTree
 import fr.free.nrw.commons.logging.LogUtils
-import fr.free.nrw.commons.media.CustomOkHttpNetworkFetcher
 import fr.free.nrw.commons.settings.Prefs
 import fr.free.nrw.commons.upload.FileUtils
 import fr.free.nrw.commons.utils.ConfigUtils.getVersionNameWithSha
@@ -83,7 +91,7 @@ class CommonsApplication : MultiDexApplication() {
     lateinit var cookieJar: CommonsCookieJar
 
     @Inject
-    lateinit var customOkHttpNetworkFetcher: CustomOkHttpNetworkFetcher
+    lateinit var okHttpClient: OkHttpClient
 
     var languageLookUpTable: AppLanguageLookUpTable? = null
         private set
@@ -116,17 +124,29 @@ class CommonsApplication : MultiDexApplication() {
             defaultPrefs.putStringSet(Prefs.MANAGED_EXIF_TAGS, defaultExifTagsSet)
         }
 
-        //        Set DownsampleEnabled to True to downsample the image in case it's heavy
-        val config = ImagePipelineConfig.newBuilder(this)
-            .setNetworkFetcher(customOkHttpNetworkFetcher)
-            .setDownsampleEnabled(true)
+        // Initialize Coil with the shared app OkHttpClient so image requests keep the
+        // existing headers, logging, timeout, and HTTP cache configuration.
+        val imageLoader = ImageLoader.Builder(this)
+            .crossfade(true)
+            .components {
+                add(OkHttpNetworkFetcherFactory(callFactory = { okHttpClient }))
+                // Skip image loading when limited connection mode is enabled
+                // (replaces the original CustomOkHttpNetworkFetcher behavior)
+                add(LimitedConnectionModeInterceptor(defaultPrefs))
+            }
+            .memoryCache {
+                MemoryCache.Builder()
+                    .maxSizePercent(this, 0.25)
+                    .build()
+            }
+            .diskCache {
+                DiskCache.Builder()
+                    .directory(cacheDir.resolve("image_cache").absolutePath.toPath())
+                    .maxSizePercent(0.02)
+                    .build()
+            }
             .build()
-        try {
-            Fresco.initialize(this, config)
-        } catch (e: Exception) {
-            Timber.e(e)
-            // TODO: Remove when we're able to initialize Fresco in test builds.
-        }
+        SingletonImageLoader.setSafe { imageLoader }
 
         createNotificationChannel(this)
 
@@ -227,11 +247,12 @@ class CommonsApplication : MultiDexApplication() {
     }
 
     /**
-     * Clear all images cache held by Fresco
+     * Clear all images cache held by Coil
      */
     private fun clearImageCache() {
-        val imagePipeline = Fresco.getImagePipeline()
-        imagePipeline.clearCaches()
+        val imageLoader = SingletonImageLoader.get(this)
+        imageLoader.memoryCache?.clear()
+        imageLoader.diskCache?.clear()
     }
 
     /**
@@ -416,3 +437,29 @@ class CommonsApplication : MultiDexApplication() {
     }
 }
 
+/**
+ * Coil interceptor that skips network image loading when limited connection mode is enabled.
+ * This replaces the original CustomOkHttpNetworkFetcher behavior from the Fresco setup.
+ */
+class LimitedConnectionModeInterceptor(
+    private val defaultKvStore: JsonKvStore
+) : CoilInterceptor {
+
+    override suspend fun intercept(chain: CoilInterceptor.Chain): ImageResult {
+        val isLimitedConnectionMode = defaultKvStore.getBoolean(
+            CommonsApplication.IS_LIMITED_CONNECTION_MODE_ENABLED, false
+        )
+        if (isLimitedConnectionMode && chain.request.data is String) {
+            val url = chain.request.data as String
+            if (url.startsWith("http://") || url.startsWith("https://")) {
+                Timber.d("Skipping image load in limited connection mode: %s", url)
+                return ErrorResult(
+                    image = null,
+                    request = chain.request,
+                    throwable = Exception("Limited connection mode enabled")
+                )
+            }
+        }
+        return chain.proceed()
+    }
+}

app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsAdapter.kt

@@ -4,10 +4,12 @@ import android.content.Context
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
+import android.widget.ImageView
 import android.widget.TextView
 import androidx.constraintlayout.widget.ConstraintLayout
 import androidx.recyclerview.widget.RecyclerView
-import com.facebook.drawee.view.SimpleDraweeView
+import coil3.load
+import coil3.request.placeholder
 import fr.free.nrw.commons.R
 import fr.free.nrw.commons.explore.depictions.WikidataItemDetailsActivity
 import fr.free.nrw.commons.upload.structure.depictions.DepictedItem
@@ -24,7 +26,7 @@ class BookmarkItemsAdapter(
     ) : RecyclerView.ViewHolder(itemView) {
         var depictsLabel: TextView = itemView.findViewById(R.id.depicts_label)
         var description: TextView = itemView.findViewById(R.id.description)
-        var depictsImage: SimpleDraweeView = itemView.findViewById(R.id.depicts_image)
+        var depictsImage: ImageView = itemView.findViewById(R.id.depicts_image)
         var layout: ConstraintLayout = itemView.findViewById(R.id.layout_item)
     }
 
@@ -48,9 +50,11 @@ class BookmarkItemsAdapter(
         holder.description.text = depictedItem.description
 
         if (depictedItem.imageUrl?.isNotBlank() == true) {
-            holder.depictsImage.setImageURI(depictedItem.imageUrl)
+            holder.depictsImage.load(depictedItem.imageUrl) {
+                placeholder(R.drawable.ic_wikidata_logo_24dp)
+            }
         } else {
-            holder.depictsImage.setActualImageResource(R.drawable.ic_wikidata_logo_24dp)
+            holder.depictsImage.setImageResource(R.drawable.ic_wikidata_logo_24dp)
         }
         holder.layout.setOnClickListener {
             WikidataItemDetailsActivity.startYourself(context, depictedItem)

app/src/main/java/fr/free/nrw/commons/category/GridViewAdapter.kt

@@ -6,8 +6,11 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import android.widget.ArrayAdapter
+import android.widget.ImageView
 import android.widget.TextView
-import com.facebook.drawee.view.SimpleDraweeView
+import coil3.load
+import coil3.request.placeholder
+import coil3.request.error
 import fr.free.nrw.commons.Media
 import fr.free.nrw.commons.R
 
@@ -71,14 +74,17 @@ class GridViewAdapter(
         )
 
         val item = data?.get(position)
-        val imageView = view.findViewById<SimpleDraweeView>(R.id.categoryImageView)
+        val imageView = view.findViewById<ImageView>(R.id.categoryImageView)
         val fileName = view.findViewById<TextView>(R.id.categoryImageTitle)
         val uploader = view.findViewById<TextView>(R.id.categoryImageAuthor)
 
         item?.let {
             fileName.text = it.mostRelevantCaption
             setUploaderView(it, uploader)
-            imageView.setImageURI(it.thumbUrl)
+            imageView.load(it.thumbUrl) {
+                placeholder(R.drawable.image_placeholder)
+                error(R.drawable.image_placeholder)
+            }
         }
 
         return view

app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.kt

@@ -6,8 +6,9 @@ import android.view.View
 import android.webkit.URLUtil
 import androidx.appcompat.app.AlertDialog
 import androidx.recyclerview.widget.RecyclerView
-import com.facebook.imagepipeline.request.ImageRequest
-import com.facebook.imagepipeline.request.ImageRequestBuilder
+import coil3.load
+import coil3.request.placeholder
+import coil3.request.error
 import fr.free.nrw.commons.Media
 import fr.free.nrw.commons.utils.MediaAttributionUtil
 import fr.free.nrw.commons.MediaDataExtractor
@@ -33,8 +34,6 @@ class ContributionViewHolder internal constructor(
     private var contribution: Contribution? = null
     private var isWikipediaButtonDisplayed = false
     private val pausingPopUp: AlertDialog
-    var imageRequest: ImageRequest? = null
-        private set
 
     init {
         binding.contributionImage.setOnClickListener { v: View? -> imageClicked() }
@@ -62,30 +61,20 @@ an upload might take a dozen seconds. */
         binding.contributionTitle.text = contribution.media.mostRelevantCaption
         setAuthorText(contribution.media)
 
-        //Removes flicker of loading image.
-        binding.contributionImage.hierarchy.fadeDuration = 0
-
-        binding.contributionImage.hierarchy.setPlaceholderImage(R.drawable.image_placeholder)
-        binding.contributionImage.hierarchy.setFailureImage(R.drawable.image_placeholder)
-
         val imageSource = chooseImageSource(
             contribution.media.thumbUrl,
             contribution.localUri
         )
         if (!TextUtils.isEmpty(imageSource)) {
-            if (URLUtil.isHttpsUrl(imageSource)) {
-                imageRequest = ImageRequestBuilder.newBuilderWithSource(Uri.parse(imageSource))
-                    .setProgressiveRenderingEnabled(true)
-                    .build()
-            } else if (URLUtil.isFileUrl(imageSource)) {
-                imageRequest = ImageRequest.fromUri(Uri.parse(imageSource))
-            } else if (imageSource != null) {
-                val file = File(imageSource)
-                imageRequest = ImageRequest.fromFile(file)
+            val data: Any = when {
+                URLUtil.isHttpsUrl(imageSource) -> imageSource!!
+                URLUtil.isFileUrl(imageSource) -> Uri.parse(imageSource)
+                imageSource != null -> File(imageSource)
+                else -> R.drawable.image_placeholder
             }
-
-            if (imageRequest != null) {
-                binding.contributionImage.setImageRequest(imageRequest)
+            binding.contributionImage.load(data) {
+                placeholder(R.drawable.image_placeholder)
+                error(R.drawable.image_placeholder)
             }
         }
 

app/src/main/java/fr/free/nrw/commons/contributions/SetWallpaperWorker.kt

@@ -5,54 +5,47 @@ import android.app.NotificationManager
 import android.app.WallpaperManager
 import android.content.Context
 import android.graphics.Bitmap
-import android.net.Uri
 import android.os.Build
 import androidx.core.app.NotificationCompat
-import androidx.work.Worker
+import androidx.work.CoroutineWorker
 import androidx.work.WorkerParameters
-import com.facebook.common.executors.CallerThreadExecutor
-import com.facebook.common.references.CloseableReference
-import com.facebook.datasource.DataSource
-import com.facebook.drawee.backends.pipeline.Fresco
-import com.facebook.imagepipeline.datasource.BaseBitmapDataSubscriber
-import com.facebook.imagepipeline.image.CloseableImage
-import com.facebook.imagepipeline.request.ImageRequestBuilder
+import coil3.SingletonImageLoader
+import coil3.request.ImageRequest
+import coil3.request.SuccessResult
+import coil3.request.allowHardware
+import coil3.toBitmap
 import fr.free.nrw.commons.R
 import timber.log.Timber
 
 class SetWallpaperWorker(context: Context, params: WorkerParameters) :
-    Worker(context, params) {
-    override fun doWork(): Result {
+    CoroutineWorker(context, params) {
+    override suspend fun doWork(): Result {
         val context = applicationContext
         createNotificationChannel(context)
         showProgressNotification(context)
 
         val imageUrl = inputData.getString("imageUrl") ?: return Result.failure()
 
-        val imageRequest = ImageRequestBuilder
-            .newBuilderWithSource(Uri.parse(imageUrl))
-            .build()
-
-        val imagePipeline = Fresco.getImagePipeline()
-        val dataSource = imagePipeline.fetchDecodedImage(imageRequest, context)
-
-        dataSource.subscribe(object : BaseBitmapDataSubscriber() {
-            public override fun onNewResultImpl(bitmap: Bitmap?) {
-                if (dataSource.isFinished && bitmap != null) {
-                    Timber.d("Bitmap loaded from url %s", imageUrl.toString())
-                    setWallpaper(context, Bitmap.createBitmap(bitmap))
-                    dataSource.close()
-                }
-            }
-
-            override fun onFailureImpl(dataSource: DataSource<CloseableReference<CloseableImage?>?>) {
-                Timber.d("Error getting bitmap from image url %s", imageUrl.toString())
+        return try {
+            val imageLoader = SingletonImageLoader.get(context)
+            val request = ImageRequest.Builder(context)
+                .data(imageUrl)
+                .allowHardware(false)
+                .build()
+            val result = imageLoader.execute(request)
+            if (result is SuccessResult) {
+                val bitmap = result.image.toBitmap()
+                setWallpaper(context, bitmap)
+            } else {
+                Timber.d("Error getting bitmap from image url %s", imageUrl)
                 showNotification(context, "Setting Wallpaper Failed", "Failed to download image.")
-                dataSource.close()
             }
-        }, CallerThreadExecutor.getInstance())
-
-        return Result.success()
+            Result.success()
+        } catch (e: Exception) {
+            Timber.e(e, "Error getting bitmap from image url %s", imageUrl)
+            showNotification(context, "Setting Wallpaper Failed", "Failed to download image.")
+            Result.failure()
+        }
     }
 
     private fun setWallpaper(context: Context, bitmap: Bitmap) {

app/src/main/java/fr/free/nrw/commons/customselector/ui/adapter/FolderAdapter.kt

@@ -7,7 +7,8 @@ import android.widget.ImageView
 import android.widget.TextView
 import androidx.recyclerview.widget.DiffUtil
 import androidx.recyclerview.widget.RecyclerView
-import com.bumptech.glide.Glide
+import coil3.load
+import coil3.request.crossfade
 import fr.free.nrw.commons.R
 import fr.free.nrw.commons.customselector.listeners.FolderClickListener
 import fr.free.nrw.commons.customselector.model.Folder
@@ -77,7 +78,9 @@ class FolderAdapter(
             }
         } else {
             val previewImage = folder.images[0]
-            Glide.with(holder.image).load(previewImage.uri).into(holder.image)
+            holder.image.load(previewImage.uri) {
+                crossfade(true)
+            }
             holder.name.text = folder.name
             holder.count.text = count.toString()
             holder.itemView.setOnClickListener {