Fix #6881: Add intent to Failed Upload notification to open Failed tab#6884
Open
Kishan8548 wants to merge 2 commits into
Open
Fix #6881: Add intent to Failed Upload notification to open Failed tab#6884Kishan8548 wants to merge 2 commits into
Kishan8548 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #6881 by making “Failed to upload” notifications actionable: tapping them now opens UploadProgressActivity and routes directly to the FAILED uploads tab.
Changes:
- Added a
PendingIntentto the failed/error upload notifications so taps launchUploadProgressActivity. - Extended
UploadWorker.getPendingIntent()to accept atargetTaband pass it via intent extras (and as the requestCode). - Updated
UploadProgressActivityto read the tab extra on launch and switch to the requested tab.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt | Adds notification PendingIntents and passes a target-tab extra via getPendingIntent() |
| app/src/main/java/fr/free/nrw/commons/upload/UploadProgressActivity.kt | Reads upload_target_tab extra and sets the initial ViewPager tab accordingly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ Generated APK variants! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6881
What changes did you make and why?
showErrorNotificationmethod inUploadWorker.ktwas missing aPendingIntent, which caused tapping on the "Failed to upload" error notification to do nothing. I added the intent to correctly launchUploadProgressActivity.UploadWorker.getPendingIntent()to accept atargetTabargument, and added it to the intent extras.targetTabas therequestCodeto ensure the Android OS treats it as a uniquePendingIntent, preventingFLAG_IMMUTABLEfrom reusing a previous intent and ignoring our extras.UploadProgressActivityto check for thisupload_target_tabextra and switch theViewPagerto the correct tab on launch.Tests performed (required)
Tested ProdDebug on POCO F6 with API level 36.
Screenshots (for UI changes only)
Screenrecorder-2026-05-12-21-17-13-782.mp4