Conversation
sivaraam
reviewed
Mar 30, 2024
Member
sivaraam
left a comment
sivaraam
left a comment
There was a problem hiding this comment.
Thank you for working on this! I've left some comments. Kindly take a look at them.
| <li>Enter relevant depictions and categories.</li> | ||
| <li>Choose a license for the image being uploaded.</li> | ||
| <li>Finish the upload.</li> | ||
| <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps">First setp to Commons</a></li> |
Comment on lines
+252
to
+256
| <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps">First setp to Commons</a></li> | ||
| <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection">Licensing guide</a></li> | ||
| <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection">Licensing policy</a></li> | ||
| <li><a href="https://commons.wikimedia.org/wiki/Commons:Categories#For_more_appropriate_categorization">Categoriztion</a></li> | ||
| <li><a href="https://commons.wikimedia.org/wiki/Commons:File_naming">File naming</a></li> |
Member
There was a problem hiding this comment.
Rather than including this in the end of the existing steps, could you consider having a separate section next to "Installation & Usage" so that these links are more prominently found.
| <li>Finish the upload.</li> | ||
| <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps">First setp to Commons</a></li> | ||
| <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection">Licensing guide</a></li> | ||
| <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection">Licensing policy</a></li> |
Member
There was a problem hiding this comment.
This should actually be a link to https://commons.wikimedia.org/wiki/Commons:Licensing
Could you kindly correct it?
| <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps">First setp to Commons</a></li> | ||
| <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection">Licensing guide</a></li> | ||
| <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection">Licensing policy</a></li> | ||
| <li><a href="https://commons.wikimedia.org/wiki/Commons:Categories#For_more_appropriate_categorization">Categoriztion</a></li> |
Member
There was a problem hiding this comment.
Categoriztion
There's a typo. This should be "Categorization"
Author
|
Ok I will correct it in this week.
…On Sun, 31 Mar, 2024, 1:33 am Kaartic Sivaraam, ***@***.***> wrote:
***@***.**** commented on this pull request.
Thank you for working on this! I've left some comments. Kindly take a look
at them.
------------------------------
In index.html
<#61 (comment)>
:
> @@ -249,6 +249,12 @@ <h2>Installation & Usage</h2>
<li>Enter relevant depictions and categories.</li>
<li>Choose a license for the image being uploaded.</li>
<li>Finish the upload.</li>
+ <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps">First setp to Commons</a></li>
setp
There is a typo here.
------------------------------
In index.html
<#61 (comment)>
:
> + <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps">First setp to Commons</a></li>
+ <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection">Licensing guide</a></li>
+ <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection">Licensing policy</a></li>
+ <li><a href="https://commons.wikimedia.org/wiki/Commons:Categories#For_more_appropriate_categorization">Categoriztion</a></li>
+ <li><a href="https://commons.wikimedia.org/wiki/Commons:File_naming">File naming</a></li>
Rather than including this in the end of the existing steps, could you
consider having a separate section next to "Installation & Usage" so that
these links are more prominently found.
------------------------------
In index.html
<#61 (comment)>
:
> @@ -249,6 +249,12 @@ <h2>Installation & Usage</h2>
<li>Enter relevant depictions and categories.</li>
<li>Choose a license for the image being uploaded.</li>
<li>Finish the upload.</li>
+ <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps">First setp to Commons</a></li>
+ <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection">Licensing guide</a></li>
+ <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection">Licensing policy</a></li>
This should actually be a link to
https://commons.wikimedia.org/wiki/Commons:Licensing
Could you kindly correct it?
------------------------------
In index.html
<#61 (comment)>
:
> @@ -249,6 +249,12 @@ <h2>Installation & Usage</h2>
<li>Enter relevant depictions and categories.</li>
<li>Choose a license for the image being uploaded.</li>
<li>Finish the upload.</li>
+ <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps">First setp to Commons</a></li>
+ <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection">Licensing guide</a></li>
+ <li><a href="https://commons.wikimedia.org/wiki/Commons:First_steps/License_selection">Licensing policy</a></li>
+ <li><a href="https://commons.wikimedia.org/wiki/Commons:Categories#For_more_appropriate_categorization">Categoriztion</a></li>
Categoriztion
There's a typo. This should be "Categorization"
—
Reply to this email directly, view it on GitHub
<#61 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZO2D4PVRATTXTIW2DHVCDTY24LANAVCNFSM6AAAAABC2JZP3SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZQGA2TCOJZGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
@misaochan @nicolas-raoul We can close this open PR. As the PR #63 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.