fix(a11y): hide decorative SVGs from assistive tech#84
Open
adityakulraj wants to merge 1 commit intocomnam90:developfrom
Open
fix(a11y): hide decorative SVGs from assistive tech#84adityakulraj wants to merge 1 commit intocomnam90:developfrom
adityakulraj wants to merge 1 commit intocomnam90:developfrom
Conversation
Author
|
@comnam90 would appreciate your review on this one too when you have time. Thanks! |
There was a problem hiding this comment.
Pull request overview
This PR improves the accessibility of the Hugo-based single-page map UI (layouts/index.html) by marking decorative inline SVG icons as hidden from assistive technologies, reducing screen reader noise while preserving existing accessible names via surrounding text and aria-labels.
Changes:
- Adds
aria-hidden="true"to decorative inline SVGs across header controls, dialogs/panels, quick links, and report links. - Adds
aria-hidden="true"to SVGs returned bygetServiceIcon()(including the fallback icon template).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-hidden="true"to decorative inline SVGs inlayouts/index.htmlTesting
git diff --check<svgtags inlayouts/index.htmlwithoutaria-hiddenCloses #78