fix(driver): statx on musl #669
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berrysoft
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes compio-driver builds on musl targets by avoiding unconditional libc::statx usage and adds a CI workflow to exercise musl via cross.
Changes:
- Add a
stat→statxconversion helper for non-gnu Linux targets. - Gate
libc::statxblocking fallbacks behind#[cfg(gnulinux)], usingstat/fstaton other Linux envs (e.g. musl). - Add a GitHub Actions workflow to run musl tests via
cross.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| compio-driver/src/sys/unix_op.rs | Introduces stat_to_statx to build a Statx-compatible struct from libc::stat on non-gnu Linux. |
| compio-driver/src/sys/iour/op.rs | Splits call_blocking for FileStat/PathStat to avoid calling libc::statx on non-gnu Linux. |
| .github/workflows/ci_test_musl.yml | Adds a new CI job intended to test musl targets using cross. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
George-Miao
reviewed
Feb 9, 2026
Berrysoft
force-pushed
the
fix/musl-statx
branch
from
ffc8b16 to
bd10fc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #668
It would be fine to use cross-rs here...