Skip to content

Comments

Config: Change default configuration of boolean cleans#78

Merged
carlos-adir merged 6 commits intomainfrom
dev/change_default_bool
Oct 28, 2025
Merged

Config: Change default configuration of boolean cleans#78
carlos-adir merged 6 commits intomainfrom
dev/change_default_bool

Conversation

@carlos-adir
Copy link
Contributor

@carlos-adir carlos-adir commented Sep 17, 2025

This PR relates to #63

This changes the default configurations when doing boolean operations.

So far every boolean operations call clean

This PR makes the operations ~, & and | not call the clean so it keeps as Lazy Operators

Also adds the function __contains__ for the Lazy operators

@carlos-adir carlos-adir self-assigned this Sep 17, 2025
@carlos-adir carlos-adir added the enhancement New feature or request label Sep 17, 2025
@carlos-adir carlos-adir marked this pull request as ready for review October 28, 2025 19:25
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.08%. Comparing base (5db24e6) to head (97b91b6).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/shapepy/bool2d/boolean.py 97.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   99.14%   99.08%   -0.06%     
==========================================
  Files          39       39              
  Lines        3844     3828      -16     
==========================================
- Hits         3811     3793      -18     
- Misses         33       35       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlos-adir carlos-adir marked this pull request as draft October 28, 2025 20:21
@carlos-adir carlos-adir marked this pull request as ready for review October 28, 2025 20:21
@carlos-adir carlos-adir merged commit 1295aae into main Oct 28, 2025
8 checks passed
@carlos-adir carlos-adir deleted the dev/change_default_bool branch October 28, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant