Skip to content

Refa: Make most objects immutable to simplify hypothesis#85

Merged
carlos-adir merged 3 commits intomainfrom
dev/immutable_bool2d
Oct 29, 2025
Merged

Refa: Make most objects immutable to simplify hypothesis#85
carlos-adir merged 3 commits intomainfrom
dev/immutable_bool2d

Conversation

@carlos-adir
Copy link
Contributor

This PR makes most of the geometry and bool2d classes as Immutable.

Functions move, scale and rotate of the bool2d no longer change the internal state of the object.

Functions move, scale and rotate were removed from the geometry.
The same functions were added into the file geometry/transform.py that creates new objects.

@carlos-adir carlos-adir self-assigned this Oct 29, 2025
@carlos-adir carlos-adir added the refactor Tasks to improve readability / performance label Oct 29, 2025
@carlos-adir carlos-adir marked this pull request as ready for review October 29, 2025 21:49
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.43%. Comparing base (1295aae) to head (1d5dbe8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   99.08%   99.43%   +0.35%     
==========================================
  Files          39       40       +1     
  Lines        3828     3724     -104     
==========================================
- Hits         3793     3703      -90     
+ Misses         35       21      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlos-adir carlos-adir merged commit 6ede2d1 into main Oct 29, 2025
10 checks passed
@carlos-adir carlos-adir deleted the dev/immutable_bool2d branch October 29, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Tasks to improve readability / performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments