Skip to content

Comments

Refa: Uncharge the IAnalytic class to make it implemented classes simpler#86

Merged
carlos-adir merged 3 commits intomainfrom
dev/refa_analytic
Nov 16, 2025
Merged

Refa: Uncharge the IAnalytic class to make it implemented classes simpler#86
carlos-adir merged 3 commits intomainfrom
dev/refa_analytic

Conversation

@carlos-adir
Copy link
Contributor

@carlos-adir carlos-adir commented Nov 16, 2025

This PR update the analytic submodule to:

  • Add eval method to be called instead of __call__, now __call__ receives only one argument. Motivation: the second parameter, the derivative is not intuitive in the __call__.
  • Make Bezier inherit from Polynomial. It didn't need to be override all the methods implemented by Polynomial
  • Erase the clean methods for analytic. We suppose they are the cleanest way possible after the constructor
  • Replace the abstract methods shift and scale to insert compose. Now it's possible to get f(g(x)).
  • Change parameters of integrate: Now it receives the domain of integration, not the quantity of times to be integrated. As result, the integrated result is a number and no longer an analytic

@carlos-adir carlos-adir self-assigned this Nov 16, 2025
@carlos-adir carlos-adir added the refactor Tasks to improve readability / performance label Nov 16, 2025
@carlos-adir carlos-adir marked this pull request as ready for review November 16, 2025 15:09
@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.34%. Comparing base (6ede2d1) to head (d4a85ad).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   99.43%   99.34%   -0.10%     
==========================================
  Files          40       40              
  Lines        3724     3657      -67     
==========================================
- Hits         3703     3633      -70     
- Misses         21       24       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlos-adir carlos-adir merged commit 77ab354 into main Nov 16, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Tasks to improve readability / performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant