Refa: Uncharge the IAnalytic class to make it implemented classes simpler#86
Merged
carlos-adir merged 3 commits intomainfrom Nov 16, 2025
Merged
Refa: Uncharge the IAnalytic class to make it implemented classes simpler#86carlos-adir merged 3 commits intomainfrom
carlos-adir merged 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 99.43% 99.34% -0.10%
==========================================
Files 40 40
Lines 3724 3657 -67
==========================================
- Hits 3703 3633 -70
- Misses 21 24 +3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR update the analytic submodule to:
evalmethod to be called instead of__call__, now__call__receives only one argument. Motivation: the second parameter, the derivative is not intuitive in the__call__.Bezierinherit fromPolynomial. It didn't need to be override all the methods implemented byPolynomialcleanmethods for analytic. We suppose they are the cleanest way possible after the constructorshiftandscaleto insertcompose. Now it's possible to getf(g(x)).integrate: Now it receives the domain of integration, not the quantity of times to be integrated. As result, the integrated result is a number and no longer an analytic